Bug 1339183 (CVE-2016-4445)

Summary:	CVE-2016-4445 setroubleshoot: insecure use of commands.getstatusoutput in sealert
Product:	[Other] Security Response	Reporter:	Tomas Hoger <thoger>
Component:	vulnerability	Assignee:	Red Hat Product Security <security-response-team>
Status:	CLOSED ERRATA	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	CC:	lvrabec, mgrepl, mmalik, plautrba, security-response-team, ssekidde, thoger
Target Milestone:	---	Keywords:	Security
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	setroubleshoot 3.2.23	Doc Type:	Bug Fix
Doc Text:	A shell command injection flaw was found in the way the setroubleshoot executed external commands. A local attacker able to trigger certain SELinux denials could use this flaw to execute arbitrary code with root privileges.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-22 09:09:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1339375, 1339377
Bug Blocks:	1332645

Description Tomas Hoger 2016-05-24 10:49:55 UTC

It was discovered that sealert executed external fix commands using commands.getstatusoutput() without properly sanitizing untrusted inputs used as command arguments.  These inputs originated from SELinux AVC messages.  A local user could use this flaw to execute arbitrary code as root if they could trigger an SELinux denial using a file with a specially crafted name.

The use of commands.getstatusoutput() was already removed upstream via the following commit:

https://github.com/fedora-selinux/setroubleshoot/commit/2d12677629ca319310f6263688bb1b7f676c01b7

Comment 1 Tomas Hoger 2016-05-24 10:53:36 UTC

Acknowledgments:

Name: Red Hat Product Security

Comment 8 Tomas Hoger 2016-06-21 11:36:48 UTC

Lifting embargo.

Comment 9 errata-xmlrpc 2016-06-21 21:24:56 UTC

This issue has been addressed in the following products:

  Red Hat Enterprise Linux 6

Via RHSA-2016:1267 https://access.redhat.com/errata/RHSA-2016:1267

Comment 10 Tomas Hoger 2016-06-22 09:04:59 UTC

This issue was fixed upstream in version 3.2.23.  The setroubleshoot packages in Red Hat Enterprise Linux 7 were updated from version 3.2.17 to version 3.2.24 via RHBA-2015:2287, released as part of Red Hat Enterprise Linux 7.2.

https://rhn.redhat.com/errata/RHBA-2015-2287.html

Therefore, this issue was corrected in that update.