Bug 1339251

Summary:	RFE preserve service.xml.old after service deletion in permanent scope
Product:	[Fedora] Fedora	Reporter:	Tomas Dolezal <todoleza>
Component:	firewalld	Assignee:	Thomas Woerner <twoerner>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Tomas Dolezal <todoleza>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jpopelka, twoerner
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-16 20:59:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1302802

Description Tomas Dolezal 2016-05-24 13:22:53 UTC

Description of problem:
currently, if one deletes service using firewall-cmd, service.xml.old file don't get updated with latest service.xml contents.

please update all --delete calls to this behaviour (zone, ipset, icmptype,service)

Version-Release number of selected component (if applicable):
v0.4.1.2-90-g5da1724

How reproducible:
always

Steps to Reproduce:
firewall-cmd --new-service=myserv --permanent
firewall-cmd --add-port 2185/udp
firewall-cmd --service myserv --add-source-port 2187/udp --permanent
firewall-cmd --delete-service myserv --permanent

Actual results:
myserv.xml with sport 2187 gets deleted
myserv.xml.old without sport 2187 but with 2185 port exists

Expected results:
myserv.xml.old contains contents of myserv.xml from before service deletion

Additional info:
having .old service file containing even older data is misleading

Comment 1 Tomas Dolezal 2016-05-24 13:24:22 UTC

fix in reproducer on 2nd line:

firewall-cmd --new-service=myserv --permanent
firewall-cmd --service myserv --add-port 2185/udp
firewall-cmd --service myserv --add-source-port 2187/udp --permanent
firewall-cmd --delete-service myserv --permanent

Comment 2 Thomas Woerner 2016-05-25 13:19:14 UTC

This also applies to zones, icmptypes and ipsets.

Comment 3 Thomas Woerner 2016-06-22 11:53:35 UTC

Fixed upstream: https://github.com/t-woerner/firewalld/commit/a83c5204d536780f14936e87b1b3197383942a9d

Comment 4 Thomas Woerner 2016-08-16 20:59:05 UTC

Fixed in firewalld-0.4.3 in F23 and up