Bug 1339361
| Summary: | Backport for api/groups to 5.5.3 request | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | John Prause <jprause> |
| Component: | API | Assignee: | abellott |
| Status: | CLOSED ERRATA | QA Contact: | Martin Kourim <mkourim> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.5.0 | CC: | cpelland, jhardy, obarenbo |
| Target Milestone: | GA | Keywords: | ZStream |
| Target Release: | 5.5.5 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | 5.5.5.2 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1337921 | Environment: | |
| Last Closed: | 2016-07-26 15:34:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1337921 | ||
| Bug Blocks: | |||
New commit detected on cfme/5.5.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=18f4651d04706e14eb85b6bef73337718ad10723 commit 18f4651d04706e14eb85b6bef73337718ad10723 Author: Alberto Bellotti <abellott> AuthorDate: Wed Nov 25 11:38:51 2015 -0500 Commit: Alberto Bellotti <abellott> CommitDate: Wed May 25 15:35:53 2016 -0400 [api] Group CRUD - Enabling post/put/patch/delete on /api/groups - Refactored/re-using parse_<type> methods - Made role/tenant fetches RBAC aware - Added filters structure validation in model - Added specs - PR Review changes https://trello.com/c/wPzTtz4S/147-api-need-full-crud-on-api-groups Original PR https://github.com/ManageIQ/manageiq/pull/5611 Clean Cherry Pick 39c8d9a, 94e535a https://bugzilla.redhat.com/show_bug.cgi?id=1337921 app/controllers/api_controller.rb | 1 + app/controllers/api_controller/groups.rb | 48 ++++++ app/controllers/api_controller/parser.rb | 52 ++++-- app/controllers/api_controller/roles.rb | 2 +- app/controllers/api_controller/tenants.rb | 11 +- app/models/miq_group.rb | 7 + config/api.yml | 6 +- spec/requests/api/groups_spec.rb | 264 ++++++++++++++++++++++++++++++ spec/requests/api/tenants_spec.rb | 3 +- 9 files changed, 370 insertions(+), 24 deletions(-) create mode 100644 app/controllers/api_controller/groups.rb create mode 100644 spec/requests/api/groups_spec.rb Manually tested creating, editing and deleting of groups. All related automated tests that verify groups creation and editing and deletion of both single and multiple groups passed. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-1488.html |
This was Backported to 5.5.z commit 18f4651d04706e14eb85b6bef73337718ad10723 [api] Group CRUD - Enabling post/put/patch/delete on /api/groups - Refactored/re-using parse_<type> methods - Made role/tenant fetches RBAC aware - Added filters structure validation in model - Added specs - PR Review changes https://trello.com/c/wPzTtz4S/147-api-need-full-crud-on-api-groups Original PR https://github.com/ManageIQ/manageiq/pull/5611 Clean Cherry Pick 39c8d9a, 94e535a https://bugzilla.redhat.com/show_bug.cgi?id=1337921