Bug 1339626

As it is, we're asking the question:

"Setting up High Availability Masters requires a load balancing solution.
Please provide a the FQDN of a host that will be configured as a proxy. (…)"

and setting the response to that to `openshift_master_cluster_hostname`. The question of whether to install haproxy on that host is a followup question:

"Should the reference haproxy load balancer be installed on this host?"

Is there something else I'm missing here?

(In reply to Samuel Munilla from comment #1)
> As it is, we're asking the question:
> 
> "Setting up High Availability Masters requires a load balancing solution.
> Please provide a the FQDN of a host that will be configured as a proxy. (…)"
> 
> and setting the response to that to `openshift_master_cluster_hostname`. The
> question of whether to install haproxy on that host is a followup question:
> 
> "Should the reference haproxy load balancer be installed on this host?"
> 
> Is there something else I'm missing here?

The request here is for the ClusterHostname setting to be set in _non_ HA deployments.

Eric, 

Through https://github.com/openshift/openshift-ansible/pull/1778 and some other subsequent work, users can set arbitrary variables in the installer configuration file by setting them under the 'deployment' header. In this case, you can edit installer.cfg.yaml like so:

[…]
deployment:
  openshift_master_cluster_hostname: <HOST>
  hosts:
    […]
  roles:
    […]

and then re-run the quick-installer in unattended mode. Is this sufficient to cover this use case or is there a desire to have it added as a question to the user in interactive mode as well?

(In reply to Samuel Munilla from comment #4)
> Eric, 
> 
> Through https://github.com/openshift/openshift-ansible/pull/1778 and some
> other subsequent work, users can set arbitrary variables in the installer
> configuration file by setting them under the 'deployment' header. In this
> case, you can edit installer.cfg.yaml like so:
> 
> […]
> deployment:
>   openshift_master_cluster_hostname: <HOST>
>   hosts:
>     […]
>   roles:
>     […]
> 
> and then re-run the quick-installer in unattended mode. Is this sufficient
> to cover this use case or is there a desire to have it added as a question
> to the user in interactive mode as well?

This "meets the need", but as this is part of the quick installer, its my opinion that this should be fixed as part of the wrapper.

https://github.com/openshift/openshift-ansible/pull/2563

(In reply to Samuel Munilla from comment #8)
> https://github.com/openshift/openshift-ansible/pull/2563

@smunilla

Is this pr is for another bug 1339621? And for this bug, i don't catch the changes, can u give a right pr link? or some info about this bug? Thx~

@smunilla

I don't find the interactive option to set ClusterHostname in attended quick install for non-ha env. If i missed any info?

https://github.com/openshift/openshift-ansible/pull/2683 has updated interactive messaging to make it clearer which question was being used to set that value.

Hi Samuel

I saw this pr has been merged into the latest puddle now. But it still has some issues:
1) "openshift_master_cluster_hostname" in hosts and installer.cfg but "openshift_master_cluster_public_hostname" in hint message.

2) For non-ha env, the cluster host name was not set to default value(master hostname) but a none value.

additional changes have been merged

Version:
atomic-openshift-utils-3.4.23-1.git.0.317b2cd.el7.noarch

Step:
1.trigger an quick install
# atomic-openshift-installer install
2.input host info(only one master) and select "n" for additional hosts.
Do you want to add additional hosts? [y/N]: n
3.It will output following message for user to make a choice:

You have chosen to install a single master cluster (non-HA).

In a single master cluster, the cluster host name (Ansible variable openshift_master_cluster_public_hostname) is set by default to the host name of the single master. In a multiple master (HA) cluster, the FQDN of a host must be provided that will be configured as a proxy. This could be either an existing load balancer configured to balance all masters on
port 8443 or a new host that would have HAProxy installed on it.

(Optional)
If you want to override the cluster host name now to something other than the default (the host name of the single master), or if you think you might add masters later to become an HA cluster and want to future proof your cluster host name choice, please provide a FQDN. Otherwise, press ENTER to continue and accept the default.

Enter hostname or IP address [None]: x.x.x.x

Result:
The cluster hostname can be set to the sepecified value in quick install.
#cat installer.cfg.yml
openshift_master_cluster_hostname: x.x.x.x
openshift_master_cluster_public_hostname: x.x.x.x

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0066