Bug 1339705

Summary: ceph-disk prepare: Error: partprobe /dev/vdb failed : Error: Error informing the kernel about modifications to partition /dev/vdb1 -- Device or resource busy.
Product: Red Hat Enterprise Linux 7 Reporter: Brian Lane <bcl>
Component: partedAssignee: Brian Lane <bcl>
Status: CLOSED ERRATA QA Contact: Release Test Team <release-test-team-automation>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 7.3CC: branto, ceph-eng-bugs, dahorak, jstodola, kdreyer, ldachary, mbukatov, nlevine, poelstra, rcyriac
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: parted-3.1-26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1336756 Environment:
Last Closed: 2016-11-04 00:10:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1336756    
Bug Blocks:    

Comment 1 Brian Lane 2016-05-25 16:38:48 UTC
It ends up that part of the problem here is that partprobe is open/closing the device 3 times while probing it. It should only open/close the RW fd once, like parted does, to minimize the udev BLKRRPART command that happens in response to the close.

Here's the proposed patch:

https://github.com/bcl/parted/commit/570802f5ac81a977735dbd9fc4c109387bdbc2c5

Which results in:

# strace -e open -o /dev/stdout partprobe /dev/sda | grep '"/dev/sda"'
open("/dev/sda", O_RDONLY)              = 3
open("/dev/sda", O_RDWR)                = 3

A single open/close.

This should stop udev from trying to issue a BLKRRPART in the middle of partprobe running. It doesn't remove the need for a short delay and udev settle before/after running partprobe.

Comment 2 Brian Lane 2016-05-25 17:24:45 UTC
*** Bug 1339675 has been marked as a duplicate of this bug. ***

Comment 7 Jan Stodola 2016-08-11 11:36:36 UTC
I'm not able to reproduce the issue with parted-3.1-27.el7 using the reproducer from comment 3, tested with 20000 iterations.

Moving to VERIFIED.

Comment 9 errata-xmlrpc 2016-11-04 00:10:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2183.html