Bug 1340119

Summary:	Could you add bash completions to runc package.
Product:	[Fedora] Fedora	Reporter:	Daniel Walsh <dwalsh>
Component:	runc	Assignee:	Jan Chaloupka <jchaloup>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	amurdaca, golang-updates, jchaloup, lsm5
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	runc-0.1.1-3.git57b9972.fc25 runc-0.1.1-3.git57b9972.fc24	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-07-10 06:00:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Daniel Walsh 2016-05-26 13:25:14 UTC

I added runc bash completions to the upstream runc package.  I also modified the make install script, so you might need to modify the way runc is installed.

Could you add a make install-bash to the spec file to add the bash completions.


Thanks.

Comment 1 Jan Chaloupka 2016-05-26 13:26:54 UTC

Sure. The upstream link https://github.com/opencontainers/runc/commit/57b997243d52f70a78cfea5e31ccb69f37450b5a.

Comment 2 Daniel Walsh 2016-05-26 13:32:45 UTC

Yup.

Comment 3 Fedora Update System 2016-05-26 15:39:41 UTC

runc-0.1.1-3.git57b9972.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-dcef7cfd52

Comment 4 Fedora Update System 2016-05-26 15:40:14 UTC

runc-0.1.1-3.git57b9972.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c791bb6712

Comment 5 Fedora Update System 2016-05-26 23:23:35 UTC

runc-0.1.1-3.git57b9972.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-dcef7cfd52

Comment 6 Fedora Update System 2016-05-26 23:27:59 UTC

runc-0.1.1-3.git57b9972.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c791bb6712

Comment 7 Daniel Walsh 2016-05-27 14:03:15 UTC

Jan, shouldn't the runc be installed in /usr/share/bash-completions/completions?

/etc/bash_completions.d/
If for admins to setup local customizations, I believe.

Comment 8 Fedora Update System 2016-07-10 06:00:51 UTC

runc-0.1.1-3.git57b9972.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.