Bug 1340141

Summary:	RFE: allow to turn on reservesys after job submission
Product:	[Retired] Beaker	Reporter:	Jan Stancek <jstancek>
Component:	web UI	Assignee:	matt jia <mjia>
Status:	CLOSED CURRENTRELEASE	QA Contact:	tools-bugs <tools-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	21	CC:	dcallagh, dowang, mjia, rjoost
Target Milestone:	23.0
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-07-07 23:11:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Stancek 2016-05-26 13:59:39 UTC

Description of problem:
Add a button to WEBUI, that allows me to trigger reservesys functionality on the fly, so that I can keep a system for an investigation. RESERVE_IF_FAIL is not suitable because tasks frequently run into known (kernel) issues, which would create large amount of unwanted reservations. 

Triggering reservesys should also turn off panic detector.

Comment 1 Dan Callaghan 2016-05-27 21:07:35 UTC

This is implemented in Beaker 23.0. On the Reservation tab of the recipe page, for a queued or running recipe which you have permission to change (owned by you or a shared group job), there is a button to change the reservation request -- that is, you can tell it either do or don't reserve at the end of the recipe and for how long.

Comment 2 Dan Callaghan 2016-05-27 21:27:40 UTC

(In reply to Jan Stancek from comment #0)
> Triggering reservesys should also turn off panic detector.

... but this piece does not seem to be, even though I thought it was. It looks like a panic while a recipe is Reserved will be reported and will cause the watchdog to be reduced to 10 minutes, which is not really desired.

Comment 3 Dan Callaghan 2016-05-27 22:28:12 UTC

(In reply to Dan Callaghan from comment #2)

Actually beaker-watchdog does try to report the panic but it fails to do so because of some server-side sanity checking. So the expected behaviour (panic should be ignored while the recipe is Reserved) is already in place.

I have filed bug 1340566 about the beaker-watchdog error, which just needs tidying up on the watchdog side so that it doesn't try to report panics for Reserved recipes.

Comment 5 Dan Callaghan 2016-06-01 13:15:53 UTC

*** Bug 1162500 has been marked as a duplicate of this bug. ***

Comment 6 Dan Callaghan 2016-07-07 23:11:32 UTC

Beaker 23.0 has been released.