Bug 1340722

Summary:	Redundant saves of vms in stable state
Product:	[oVirt] ovirt-engine	Reporter:	Arik <ahadas>
Component:	BLL.Virt	Assignee:	Arik <ahadas>
Status:	CLOSED CURRENTRELEASE	QA Contact:	sefi litmanovich <slitmano>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.0.0	CC:	bugs, mgoldboi, michal.skrivanek, tjelinek
Target Milestone:	ovirt-4.0.6	Keywords:	Performance, Regression
Target Release:	4.0.6.1	Flags:	rule-engine: ovirt-4.0.z+ rule-engine: blocker+ rule-engine: planning_ack+ rule-engine: devel_ack+ mavital: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-18 07:26:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1388462

Description Arik 2016-05-30 07:35:30 UTC

Description of problem:
When the system is in 'stable' state, meaning no status change or any operation on the running VMs, the VMs are still being dumped into the database by the monitoring in each polling (statistics) cycle because the monitoring thinks that the following fields are changed:
- hash
- guest agent nic hash
- current cd

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. have a system in stable state
2.
3.

Actual results:
In each statistics cycle all VMs are updated

Expected results:
No batch update for VMs should occur by the monitoring

Additional info:

Comment 1 Arik 2016-05-30 19:34:33 UTC

These fields as well:
- guest memory free
- guest memory buffered
- guest memory cached

Comment 2 Red Hat Bugzilla Rules Engine 2016-06-03 07:45:48 UTC

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 3 Michal Skrivanek 2016-10-26 12:32:38 UTC

seems like an easy win in 4.0.z, let's backport it

Comment 4 Arik 2016-10-27 07:58:37 UTC

https://gerrit.ovirt.org/#/c/58303/ was already backported to 4.0.3 as part of the solution to bz 1366786

Comment 5 Yaniv Kaul 2016-11-08 12:31:00 UTC

(In reply to Michal Skrivanek from comment #3)
> seems like an easy win in 4.0.z, let's backport it

I'd be happy to see it in 4.0.6.

Comment 6 Tomas Jelinek 2016-11-09 10:12:34 UTC

made the 4.0.6, setting moving target

Comment 7 Red Hat Bugzilla Rules Engine 2016-11-17 11:13:48 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 8 sefi litmanovich 2016-12-01 13:12:45 UTC

Verified with rhevm-4.0.6.1-0.1.el7ev.noarch.

Have 3 running vms with rhevm-guest-agent-common-1.0.12-3.el7ev.noarch. When system is stable and no action is done, vm_dynamic doesn't change (monitored it for approx. an hour), only when I changed_CD for one of the vms the table was updated as it should.

- guest memory free
- guest memory buffered
- guest memory cached

These values moved to vm_statistics table as changed in one of the related patches.

Please notify me if this test isn't enough.