Bug 1340735

Summary:	[platformmanagement_public_714]Should not update the DC everytime when automatic set to false without ConfigChangeTrigger
Product:	OKD	Reporter:	zhou ying <yinzhou>
Component:	Deployments	Assignee:	Michail Kargakis <mkargaki>
Status:	CLOSED CURRENTRELEASE	QA Contact:	zhou ying <yinzhou>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.x	CC:	aos-bugs
Target Milestone:	---	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-19 13:55:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description zhou ying 2016-05-30 08:12:43 UTC

Description of problem:
In DeploymentConfig set automatic to false and delete the ConfigChangeController, trigger build for times, the subsequent Image was updated to the DeploymentConfig for timely.

Version-Release number of selected component (if applicable):
openshift v1.3.0-alpha.1-41-g681170a
kubernetes v1.3.0-alpha.1-331-g0522e63
etcd 2.3.0

How reproducible:
always

Steps to Reproduce:
1. Download file from:https://raw.githubusercontent.com/openshift/origin/master/examples/sample-app/application-template-stibuild.json, change automatic to false, and delete the ConfigChangeController;
2. Use command to create app:
  `oc process -f application-template-stibuild.json|oc create -f -`
3. Wait for the first build to completed, check the DeploymentConfig;
4. Start new build, wait for the build completed, and check the DeploymentConfig.


Actual results:
3. The Image info was updated to the DeploymentConfig firstly;
4. The subsequent Image  was updated to the DeploymentConfig again. 

Expected results:
4. The subsequent Image should not be updated to the DeploymentConfig again.

Additional info:
When with ConfigChangeController and automatic set to false not update the DeploymentConfig with the subsequent Image.

Comment 1 openshift-github-bot 2016-06-02 20:45:29 UTC

Commit pushed to master at https://github.com/openshift/origin

https://github.com/openshift/origin/commit/88bd1efa96edd44a696bf34a832a146b48f82b1d
Bug 1340735: update dc image at most once on automatic=false

Images were constantly updated before the initial deployment would
kick off. Not anymore.

Comment 2 zhou ying 2016-06-03 10:46:09 UTC

The issue has fixed , confirmed with
openshift v1.3.0-alpha.1-106-g9089acc
kubernetes v1.3.0-alpha.1-331-g0522e63
etcd 2.3.0

[root@ip-172-18-8-77 amd64]# oc describe is origin-ruby-sample
Name:			origin-ruby-sample
Namespace:		zhouy
Created:		30 minutes ago
Labels:			template=application-template-stibuild
Annotations:		<none>
Docker Pull Spec:	172.30.92.251:5000/zhouy/origin-ruby-sample

Tag	Spec		Created		PullSpec								Image
latest	<pushed>	18 minutes ago	172.30.92.251:5000/zhouy/origin-ruby-sample@sha256:b1c77c42c61f52...	<same>
			24 minutes ago	172.30.92.251:5000/zhouy/origin-ruby-sample@sha256:ac8ec55094deff...	<same>
			26 minutes ago	172.30.92.251:5000/zhouy/origin-ruby-sample@sha256:12711806ceda8c...	<same>


[root@ip-172-18-8-77 amd64]# oc get dc frontend -o json |grep image
                "imageChangeParams": {
                        "image": "172.30.92.251:5000/zhouy/origin-ruby-sample@sha256:12711806ceda8ce5f5b12e1f5a60e7262018d5410a03dde00357ed785de30a74",
                        "imagePullPolicy": "IfNotPresent",