Bug 1340884
| Summary: | Review Request: krita - A sketching and painting program | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Helio Chissini de Castro <helio> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, ngompa13, package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-05-31 20:59:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Helio Chissini de Castro
2016-05-30 14:42:46 UTC
This used to be a part of the calligra package. It has now become a standalone upstream release with Krita 3 (the KF5 port). Exactly. That's why the new package I can review, some initial comments:
1. MUST: drop -devel subpkg, there's no public API (headers), better to omit
%{_libdir}/libkrita*.so
from packaging
2. SHOULD consider a -libs subpkg, for multilib friendliness, to include shared libraries and plugins, basically:
%{_libdir}/libkrita*.so.*
3. SHOULD support better upgrade path from calligra-krita, add
Obsoletes: calligra-krita < 3.0
Provides: calligra-krita = %{version}-%{release}
# add to -libs pkg, if you choose to create one per item 2
Obsoletes: calligra-krita-libs < 3.0
Provides: calligra-krita-libs = %{version}-%{release}
4. Source URL invalid, MUST use (something like)
Source0: http://download.kde.org/stable/krita/%{version}/krita-%{version}.tgz
(without this, I cannot verify sources either, since the Source used currently has a different extension .tar.xz)
5. MUST add missing icon/mimetype/shlib scriptlets:
%post
touch --no-create %{_datadir}/icons/hicolor &> /dev/null || :
%posttrans
gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || :
update-desktop-database -q &> /dev/null ||:
%postun
if [ $1 -eq 0 ] ; then
touch --no-create %{_datadir}/icons/hicolor &> /dev/null || :
gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || :
update-desktop-database -q &> /dev/null ||:
fi
and to -libs:
%post libs -p /sbin/ldconfig
%postun libs -p /sbin/ldconfig
6. SHOULD simplify Summary/Description, mentioning "FREE" is extraneous (everything in fedora is free already), I'd suggest just
Summary: A sketching and painting program
Updated with all changes: Spec URL: https://heliocastro.fedorapeople.org/krita/krita.spec SRPM URL: https://heliocastro.fedorapeople.org/krita/krita-3.0-2.fc24.src.rpm sources: ok $ md5sum *.tgz beb7140471d1b6b0ae92d664743c067f krita-3.0.tgz naming: ok license: ok Looks good, APPROVED pkgdb request submitted Hold on... Why are the krita libraries included in both krita-libs and krita itself? They should only be in krita-libs. you're right, sorry. I'd only checked that the -libs pkg was created, not that it's contents were removed from the main pkg too. We can fix that up prior to doing any official builds. importing into rawhide, and fixing up items |