Bug 1340995
Summary: | Bricks are starting when server quorum not met. | |||
---|---|---|---|---|
Product: | [Red Hat Storage] Red Hat Gluster Storage | Reporter: | Byreddy <bsrirama> | |
Component: | glusterd | Assignee: | Samikshan Bairagya <sbairagy> | |
Status: | CLOSED ERRATA | QA Contact: | Byreddy <bsrirama> | |
Severity: | medium | Docs Contact: | ||
Priority: | unspecified | |||
Version: | rhgs-3.1 | CC: | amukherj, rcyriac, rhinduja, rhs-bugs, sasundar, sbairagy, storage-qa-internal, vbellur | |
Target Milestone: | --- | |||
Target Release: | RHGS 3.2.0 | |||
Hardware: | x86_64 | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | glusterfs-3.8.4-1 | Doc Type: | Bug Fix | |
Doc Text: |
Previously, when glusterd was restarted, bricks were started even when server quorum was not met. This update ensures that bricks are stopped if server quorum is no longer met, or if server quorum is disabled, to ensure that bricks in maintenance are not started incorrectly.
|
Story Points: | --- | |
Clone Of: | ||||
: | 1345727 (view as bug list) | Environment: | ||
Last Closed: | 2017-03-23 05:33:54 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1345727, 1351522, 1351530, 1353814 |
Description
Byreddy
2016-05-31 05:00:44 UTC
This is indeed a bug. Since the volume version has been changed while setting the server side quorum when N2 comes up it will go for importing the volume from other nodes. On that code path GlusterD invokes glusterd_start_bricks () which never checks for quorum and resulting into starting the bricks. This doesn't look like a critical issue at this stage. Killing the bricks processes on N2 and restarting GlusterD should be able to ensure that quorum is met and bricks are not started. With this explanation moving this bug to 3.2.0 My analysis is incorrect here. Since cluster.server-quorum-ratio is applicable for all the volumes the volume's version will not get incremented and we will not eventually hit the code path of importing the volume. We'd need to find out a way to take a decision whether to start/stop the brick(s) based on when this global option is synced. http://review.gluster.org/#/c/14758 (glusterd: Don't start bricks if server quorum is not met) posted for review Samikshan, Any upstream patch posted for review makes the respective downstream bug moved to POST state. This bug will not be moved to MODIFIED till the same fix is available in the downstream codebase. HTH, Atin (In reply to Atin Mukherjee from comment #6) > Samikshan, > > Any upstream patch posted for review makes the respective downstream bug > moved to POST state. This bug will not be moved to MODIFIED till the same > fix is available in the downstream codebase. > Yes. I hadn't realized I had selected MODIFIED by mistake. Thanks for changing it to POST. Upstream mainline: http://review.gluster.org/14758 http://review.gluster.org/15183 Upstream 3.8: http://review.gluster.org/14876 http://review.gluster.org/15186 Fixes are available in rhgs-3.2.0 as part of rebase to GlusterFS 3.8.4 Verified this bug using the build - glusterfs-3.8.4-1. Fix is working well, moving to verified state. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2017-0486.html |