Bug 1341007

Summary:	gfapi : throwing warning message for unused variable in glfs_h_find_handle()
Product:	[Community] GlusterFS	Reporter:	Jiffin <jthottan>
Component:	libgfapi	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sudhir D <sdharane>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, ndevos
Target Milestone:	---	Keywords:	EasyFix, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-27 18:12:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jiffin 2016-05-31 05:52:20 UTC

Description of problem:
The variable ret is declared in glfs_h_find_handle(), but never used. So while compiling following warning message will be printed. glfs-handleops.c: In function ‘glfs_h_find_handle’: glfs-handleops.c:1813:29: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] int ret = -1;

Version-Release number of selected component (if applicable):
mainline

How reproducible:
always

Steps to Reproduce:
1.Compile latest master code


Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-05-31 05:53:32 UTC

REVIEW: http://review.gluster.org/14524 (gfapi/upcall : remove unused variable ret in glfs_h_find_handle) posted (#2) for review on master by jiffin tony Thottan (jthottan)

Comment 2 Vijay Bellur 2016-05-31 11:44:45 UTC

COMMIT: http://review.gluster.org/14524 committed in master by Niels de Vos (ndevos) 
------
commit 719e9f2228027a85df5c7b7b3e5fb4494bfbf186
Author: Jiffin Tony Thottan <jthottan>
Date:   Tue May 24 18:52:52 2016 +0530

    gfapi/upcall : remove unused variable ret in glfs_h_find_handle
    
    The variable ret is declared in glfs_h_find_handle(), but never used.
    So while compiling following warning message will be printed.
    glfs-handleops.c: In function ‘glfs_h_find_handle’:
    glfs-handleops.c:1813:29: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
             int                 ret = -1;
                                 ^
    
    Change-Id: I599b7a4e87184aacd6c937e946defd4e270509c4
    BUG: 1341007
    Signed-off-by: Jiffin Tony Thottan <jthottan>
    Reviewed-on: http://review.gluster.org/14524
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Shyamsundar 2017-03-27 18:12:03 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/