Bug 1341145

Summary: Internal engine error when editing cluster if there is an external VM
Product: [oVirt] ovirt-engine Reporter: Tomas Jelinek <tjelinek>
Component: Backend.CoreAssignee: Marek Libra <mlibra>
Status: CLOSED CURRENTRELEASE QA Contact: Nisim Simsolo <nsimsolo>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.0.0CC: bugs, gklein, michal.skrivanek, nsimsolo
Target Milestone: ovirt-4.0.0-rc3Flags: rule-engine: ovirt-4.0.0+
rule-engine: planning_ack+
rule-engine: devel_ack+
mavital: testing_ack+
Target Release: 4.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.0.0.5 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-25 12:43:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Virt RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tomas Jelinek 2016-05-31 11:11:54 UTC
Steps:
1: have an env with external Vms (at least one)
2: edit the cluster

Result:
Internal engine error is reported

Expected result:
Some descriptive validation error is reported that can not edit the cluster if there are external VMs in it.
Or it could ignore the external VMs and not try to update tham

Additional info:
Fails because the UpdateVmCommand.validate() returns false making the UpdateClusterCommand call setSucceeded(false) in because !updateVms()

Comment 2 Nisim Simsolo 2016-08-22 14:14:01 UTC
Verified: 
ovirt-engine-4.0.2.7-0.1.el7ev.noarch
qemu-kvm-rhev-2.3.0-31.el7_2.21.x86_64
vdsm-4.18.11-1.el7ev.x86_64
libvirt-client-1.2.17-13.el7_2.5.x86_64
sanlock-3.2.4-3.el7_2.x86_64