Bug 1341672

Summary:	Review Request: perl-Test2-AsyncSubtest - Tools for writing asynchronous subtest
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Test2-AsyncSubtest-0.000016-1.fc25	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-08 14:18:46 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1341444

Description Petr Pisar 2016-06-01 13:03:35 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Test2-AsyncSubtest/perl-Test2-AsyncSubtest.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Test2-AsyncSubtest/perl-Test2-AsyncSubtest-0.000016-1.fc25.src.rpm
Description:
These are tools for writing asynchronous subtests. Asynchronous subtests are
subtests which can be started and stashed so that they can continue to receive
events while other events are also being generated.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-06-08 11:47:41 UTC

Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test2-AsyncSubtest-0.000016-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(List::Util)
      1 perl(Scalar::Util)
      1 perl(Scope::Guard)
      1 perl(Test2::API) >= 1.302015
      1 perl(Test2::API::Context)
      1 perl(Test2::AsyncSubtest)
      1 perl(Test2::AsyncSubtest::Event::Attach)
      1 perl(Test2::AsyncSubtest::Event::Detach)
      1 perl(Test2::AsyncSubtest::Hub)
      1 perl(Test2::Event)
      1 perl(Test2::Event::Exception)
      1 perl(Test2::Hub::Subtest)
      1 perl(Test2::IPC)
      1 perl(Test2::Util)
      1 perl(Test2::Util::HashBase)
      1 perl(Test2::Util::Trace)
      1 perl(Time::HiRes)
      1 perl(base)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test2-AsyncSubtest-0.000016-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(Test2::AsyncSubtest) = 0.000016
      1 perl(Test2::AsyncSubtest::Event::Attach) = 0.000016
      1 perl(Test2::AsyncSubtest::Event::Detach) = 0.000016
      1 perl(Test2::AsyncSubtest::Hub) = 0.000016
      1 perl(Test2::Tools::AsyncSubtest) = 0.000016
      1 perl-Test2-AsyncSubtest = 0.000016-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-Test2-AsyncSubtest*
perl-Test2-AsyncSubtest.noarch: W: spelling-error Summary(en_US) subtest -> subtlest, sub test, sub-test
perl-Test2-AsyncSubtest.noarch: W: spelling-error %description -l en_US subtests -> sub tests, sub-tests, subtexts
perl-Test2-AsyncSubtest.src: W: spelling-error Summary(en_US) subtest -> subtlest, sub test, sub-test
perl-Test2-AsyncSubtest.src: W: spelling-error %description -l en_US subtests -> sub tests, sub-tests, subtexts
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Rpmlint is ok


The package looks good.
Approved.

Comment 2 Gwyn Ciesla 2016-06-08 14:05:15 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test2-AsyncSubtest

Comment 3 Petr Pisar 2016-06-08 14:18:46 UTC

Thank you for the review and the repository.