Bug 1341913

Summary: off-by-one error in base64_decode_value
Product: Red Hat Enterprise Linux 7 Reporter: Doran Moppert <dmoppert>
Component: rpmAssignee: Florian Festi <ffesti>
Status: CLOSED ERRATA QA Contact: Jan Blazek <jblazek>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.4   
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: rpm-4.11.3-22.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 19:33:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1380360    
Attachments:
Description Flags
simple demo of incorrect result by copying static function into standalone program none

Description Doran Moppert 2016-06-02 02:46:36 UTC 
Created attachment 1163869 [details]
simple demo of incorrect result by copying static function into standalone program

Description of problem:

base64_decode_value() in rpmio/base64.c incorrectly uses > instead of >= when bounds checking array.  This leads to base64_decode_value(123) 
returning a garbage value rather than -1.


Version-Release number of selected component (if applicable):

Present in all versions.


How reproducible:

100%


Steps to Reproduce:

Attached file demonstrates the function's incorrect result (should be -1, result is instead arbitrary).


Additional info:

See upstream bug https://github.com/rpm-software-management/rpm/pull/68

Originally disclosed by jwakely to secalert@ as a potential security issue.
Comment 6 errata-xmlrpc 2017-08-01 19:33:33 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2160