Bug 1342252

Summary: [geo-rep]: Remove brick with geo-rep session fails with latest build
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Rahul Hinduja <rhinduja>
Component: geo-replicationAssignee: Kotresh HR <khiremat>
Status: CLOSED ERRATA QA Contact: Rahul Hinduja <rhinduja>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: rhgs-3.1CC: avishwan, csaba, rcyriac
Target Milestone: ---Keywords: Regression, ZStream
Target Release: RHGS 3.1.3   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.7.9-8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-23 05:25:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1311817    

Description Rahul Hinduja 2016-06-02 18:18:37 UTC 
Description of problem:
=======================

Remove brick commit operation fails having geo-rep session even when geo-rep session is in stopped state. 

[root@dhcp37-88 ~]# gluster volume geo-replication Master 10.70.37.52::Slave status
 
MASTER NODE     MASTER VOL    MASTER BRICK      SLAVE USER    SLAVE                 SLAVE NODE    STATUS     CRAWL STATUS    LAST_SYNCED          
---------------------------------------------------------------------------------------------------------------------------------------
10.70.37.88     Master        /rhs/brick1/b1    root          10.70.37.52::Slave    N/A           Stopped    N/A             N/A                  
10.70.37.88     Master        /rhs/brick2/b4    root          10.70.37.52::Slave    N/A           Stopped    N/A             N/A                  
10.70.37.43     Master        /rhs/brick1/b2    root          10.70.37.52::Slave    N/A           Stopped    N/A             N/A                  
10.70.37.43     Master        /rhs/brick2/b5    root          10.70.37.52::Slave    N/A           Stopped    N/A             N/A                  
10.70.37.213    Master        /rhs/brick1/b3    root          10.70.37.52::Slave    N/A           Stopped    N/A             N/A                  
10.70.37.213    Master        /rhs/brick2/b6    root          10.70.37.52::Slave    N/A           Stopped    N/A             N/A                  
[root@dhcp37-88 ~]# gluster volume remove-brick Master 10.70.37.43:/rhs/brick2/b5 10.70.37.213:/rhs/brick2/b6 commit
Removing brick(s) can result in data loss. Do you want to Continue? (y/n) y
volume remove-brick commit: failed: geo-replication sessions are active for the volume Master.
Stop geo-replication sessions involved in this volume. Use 'volume geo-replication status' command for more info.
[root@dhcp37-88 ~]# 

This again looks to me with the recent changes of identifying session. 

Version-Release number of selected component (if applicable):
=============================================================
glusterfs-3.7.9-7


How reproducible:
=================
Always


Steps to Reproduce:
===================
1. Create geo-rep session
2. Remove Master Brick (Start)
3. Stop geo-rep session
4. Commit Master Brick

Actual results:
===============

Commit brick fails with complain that the session is active while session is in stopped state.
Comment 5 Kotresh HR 2016-06-03 09:10:09 UTC 
Upstream Patch:
http://review.gluster.org/#/c/14636/1 (master)
Comment 8 Aravinda VK 2016-06-03 18:57:34 UTC 
Patches are posted to upstream and downstream. Root cause is same as BZ 1342261

https://bugzilla.redhat.com/show_bug.cgi?id=1342261#c6
Upstream Patches:
http://review.gluster.org/14636 (master)
http://review.gluster.org/14637 (3.7) 
http://review.gluster.org/14645 (3.8)

Downstream Patch:
https://code.engineering.redhat.com/gerrit/#/c/75887/
Comment 10 Rahul Hinduja 2016-06-04 10:33:38 UTC 
Verified with build: glusterfs-3.7.9-8

Remove brick operation after stopping geo-replication is successful on master and slave. 

Moving this bz to verified state.
Comment 13 errata-xmlrpc 2016-06-23 05:25:39 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1240