Bug 1342387

Summary:	Log parameters such as the gfid, fd address, offset and length of the reads upon failure for easier debugging
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	posix	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.8.0	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1341009	Environment:
Last Closed:	2016-06-16 12:33:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1341009
Bug Blocks:	1342348

Description Krutika Dhananjay 2016-06-03 07:20:34 UTC

+++ This bug was initially created as a clone of Bug #1341009 +++

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-05-31 01:54:23 EDT ---

REVIEW: http://review.gluster.org/14271 (storage/posix: Print offset,size and gfid too when readv fails) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Vijay Bellur on 2016-05-31 05:13:37 EDT ---

COMMIT: http://review.gluster.org/14271 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit b5590f1db641a22ea515c9c4760a593d3342ffa0
Author: Krutika Dhananjay <kdhananj>
Date:   Mon May 9 16:53:19 2016 +0530

    storage/posix: Print offset,size and gfid too when readv fails
    
    ... for better debuggability.
    
    Here's a sample log:
    
    [2016-05-31 05:18:34.893951] E [MSGID: 113040] [posix.c:3089:posix_readv]
    0-dis-posix: read failed on gfid=3744d34b-f798-4ce2-b421-cc632a9903bd,
    fd=0x7f8b3c015abc, offset=131072 size=131072 [Invalid argument]
    
    Change-Id: I069c17fecbb01a4a2b5dea1eb482c7f56a191fd3
    BUG: 1341009
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/14271
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Ashish Pandey <aspandey>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    CentOS-regression: Gluster Build System <jenkins.com>

Comment 1 Vijay Bellur 2016-06-03 07:22:35 UTC

REVIEW: http://review.gluster.org/14635 (storage/posix: Print offset,size and gfid too when readv fails) posted (#1) for review on release-3.8 by Krutika Dhananjay (kdhananj)

Comment 2 Vijay Bellur 2016-06-08 19:34:20 UTC

COMMIT: http://review.gluster.org/14635 committed in release-3.8 by Niels de Vos (ndevos) 
------
commit 9c6f0d0ad7a1212f451f3cc502da3329c3534c31
Author: Krutika Dhananjay <kdhananj>
Date:   Mon May 9 16:53:19 2016 +0530

    storage/posix: Print offset,size and gfid too when readv fails
    
    ... for better debuggability.
    
            Backport of: http://review.gluster.org/#/c/14271/
    
    Here's a sample log:
    
    [2016-05-31 05:18:34.893951] E [MSGID: 113040] [posix.c:3089:posix_readv]
    0-dis-posix: read failed on gfid=3744d34b-f798-4ce2-b421-cc632a9903bd,
    fd=0x7f8b3c015abc, offset=131072 size=131072 [Invalid argument]
    
    Change-Id: Ied4d6f5260c1e371955c03bdea0cb77c3426ba33
    BUG: 1342387
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/14635
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2016-06-16 12:33:36 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user