Bug 1342406
Summary: | [RFE] Use git fetch remote URL as URL field in RPM metadata | ||||||
---|---|---|---|---|---|---|---|
Product: | [Retired] Beaker | Reporter: | Miroslav Vadkerti <mvadkert> | ||||
Component: | command line | Assignee: | Dan Callaghan <dcallagh> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | tools-bugs <tools-bugs> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | develop | CC: | dcallagh, dowang, mjia, rjoost | ||||
Target Milestone: | 23.2 | Keywords: | FutureFeature, Patch | ||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2016-08-29 03:21:27 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Miroslav Vadkerti
2016-06-03 08:34:29 UTC
Created attachment 1164372 [details]
Patch for the RFE against master/HEAD of rhts git repository
Dear Miroslav, does this bug need a NEEDINFO from Dan? Maybe you wanted to set the review flag? Regardless... Yes this sounds like a great idea. The patch looks okay, I would suggest it might be simpler to just make rhts-mk-build-package figure out the SCM URL instead of doing it in the Makefile. I will have a go at adjusting the patch and post it to Gerrit. Well, it does not, that is just my way how to get attention :) Sorry for the confusion, we do not use review flag in my team, but I will try to remember that when attaching patches next time. (In reply to Roman Joost from comment #2) > Dear Miroslav, > > does this bug need a NEEDINFO from Dan? Maybe you wanted to set the review > flag? (In reply to Dan Callaghan from comment #3) > Regardless... Yes this sounds like a great idea. > > The patch looks okay, I would suggest it might be simpler to just make > rhts-mk-build-package figure out the SCM URL instead of doing it in the > Makefile. I will have a go at adjusting the patch and post it to Gerrit. Yes, sure, I was thinking about that too, but this seemed to me as a more generic solution. Anyway, I am ok with doing this in python right away. And BTW, getting the URL can be done simply by: git config --get remote.origin.url Which works in RHEL6 and RHEL7 just fine. I wonder if we should also include the subdirectory in the # anchor, as in: git://git.beaker-project.org/beaker-core-tasks#virt/install so that you can distinguish between multiple tasks living in subdirectories under a single git repository. The # anchor syntax matches what restraint accepts. http://gerrit.beaker-project.org/4966 I added in svn and cvs support too although I think everyone is keeping their tasks in git these days. (In reply to Dan Callaghan from comment #6) > I wonder if we should also include the subdirectory in the # anchor, as in: > > git://git.beaker-project.org/beaker-core-tasks#virt/install > > so that you can distinguish between multiple tasks living in subdirectories > under a single git repository. The # anchor syntax matches what restraint > accepts. +1 ... that sounds like a neat idea. Tagged as rhts 4.71. rhts 4.71 has been released. |