Bug 1342634

Summary: [georep]: Stopping volume fails if it has geo-rep session (Even in stopped state)
Product: [Community] GlusterFS Reporter: Kotresh HR <khiremat>
Component: geo-replicationAssignee: Kotresh HR <khiremat>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 3.8.0CC: avishwan, bugs, csaba, rhinduja, storage-qa-internal
Target Milestone: ---Keywords: Regression, ZStream
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.8.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1342431 Environment:
Last Closed: 2016-06-16 12:33:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1342261, 1342420, 1342431    
Bug Blocks:    

Description Kotresh HR 2016-06-03 18:01:36 UTC 
+++ This bug was initially created as a clone of Bug #1342431 +++

+++ This bug was initially created as a clone of Bug #1342420 +++

+++ This bug was initially created as a clone of Bug #1342261 +++

Description of problem:
=======================

Pre-requisite of stopping volume is to stop geo-rep session. Even if geo-rep session is stopped, it fails complaining that the geo-rep session is ACTIVE.

[root@dhcp37-88 scripts]# gluster volume stop MASTER
Stopping volume will make its data inaccessible. Do you want to continue? (y/n) y
volume stop: MASTER: failed: geo-replication sessions are active for the volume MASTER.
Stop geo-replication sessions involved in this volume. Use 'volume geo-replication status' command for more info.
[root@dhcp37-88 scripts]# gluster volume geo-replication status
 
MASTER NODE     MASTER VOL    MASTER BRICK      SLAVE USER    SLAVE                       SLAVE NODE    STATUS     CRAWL STATUS    LAST_SYNCED          
---------------------------------------------------------------------------------------------------------------------------------------------
10.70.37.88     MASTER        /rhs/brick1/b1    root          ssh://10.70.37.52::SLAVE    N/A           Stopped    N/A             N/A                  
10.70.37.88     MASTER        /rhs/brick2/b4    root          ssh://10.70.37.52::SLAVE    N/A           Stopped    N/A             N/A                  
10.70.37.213    MASTER        /rhs/brick1/b3    root          ssh://10.70.37.52::SLAVE    N/A           Stopped    N/A             N/A                  
10.70.37.213    MASTER        /rhs/brick2/b6    root          ssh://10.70.37.52::SLAVE    N/A           Stopped    N/A             N/A                  
10.70.37.43     MASTER        /rhs/brick1/b2    root          ssh://10.70.37.52::SLAVE    N/A           Stopped    N/A             N/A                  
10.70.37.43     MASTER        /rhs/brick2/b5    root          ssh://10.70.37.52::SLAVE    N/A           Stopped    N/A             N/A                  
[root@dhcp37-88 scripts]# gluster volume list
MASTER
gluster_shared_storage
[root@dhcp37-88 scripts]# 



Version-Release number of selected component (if applicable):
=============================================================



How reproducible:
=================
Always


Steps to Reproduce:
===================
1. Create geo-rep session between master and slave
2. Stop geo-rep session
3. Stop volume

Actual results:
===============

It fails complaining that the geo-rep session is active. 

Expected results:
=================
Volume stop should succeed
Comment 1 Vijay Bellur 2016-06-03 18:03:43 UTC 
REVIEW: http://review.gluster.org/14645 (geo-rep: Fix volume stop with geo-rep session) posted (#1) for review on release-3.8 by Kotresh HR (khiremat)
Comment 2 Vijay Bellur 2016-06-06 06:51:15 UTC 
COMMIT: http://review.gluster.org/14645 committed in release-3.8 by Aravinda VK (avishwan) 
------
commit 0bbeef54babe08413f8e7f0e7d25e7fe184b19d1
Author: Aravinda VK <avishwan>
Date:   Fri Jun 3 13:07:24 2016 +0530

    geo-rep: Fix volume stop with geo-rep session
    
    Backport of http://review.gluster.org/14636
    
    The slave volume uuid is appended to slave_url
    which is saved in 'gsync_slaves' dictionary with
    the commit "http://review.gluster.org/13111".
    But the gsyncd expects slave_url with out slave
    volume uuid otherwise it fails which in turn
    fails volume stop with geo-rep. This patch
    fixes the same.
    
    Change-Id: I036f4fce43115ff848daebfe1b2c58765cffab5a
    BUG: 1342634
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/14645
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Aravinda VK <avishwan>
Comment 3 Niels de Vos 2016-06-16 12:33:36 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user