Bug 1342740

Summary: lto cause industries to be broken and more bugs
Product: [Fedora] Fedora Reporter: redhat
Component: openttdAssignee: Felix Kaechele <felix>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 24CC: atorkhov, felix
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: openttd-1.6.1-1.fc22 openttd-1.6.1-1.fc23 openttd-1.6.1-1.fc24 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-12 02:21:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description redhat 2016-06-04 14:51:32 UTC
Description of problem:
When starting a game, only one industry is properly initialized, all others are not producing anything and clicking them will actually result in opening the info window for the only working (which always seems to be a coal mine). I noticed even more problems (e.g. it's possible to play the game over network, if the other side has a non-broken game, but network game will die every now and then) and I guess they are all caused by the same problem (see Additional info section).

Apparently it's not possible to actually play the game with this build.

Version-Release number of selected component (if applicable):
1.6.0-1.fc24.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Start the game
2. Start a single player game with random map
3. After game started, click on the first industry you see

Actual results:
You see the info window of some random coal mine, which is not the one you clicked on (if you did not accidentally clicked on that single one)

Expected results:
You see the info window of exactly the industry you clicked on.

Additional info:
I rebuild the game from the rpm spec to ensure it's not a random build error and got the same result. I then noticed that link time optimizations are enabled in the spec (--enable-lto). I disabled them by removing this option and got a working build that did not suffer from the problems described above.

I assume that this is actually an upstream bug (memory leak or whatever) and that enabling link time optimizations trigger it, but nonetheless, I guess we should disable lto in Fedora to have the game working.

Comment 1 Fedora Update System 2016-06-30 23:15:16 UTC
openttd-1.6.1-1.fc24 grfcodec-6.0.6-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-526e5981d2

Comment 2 Fedora Update System 2016-06-30 23:15:35 UTC
openttd-1.6.1-1.fc23 grfcodec-6.0.6-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f619d13dbd

Comment 3 Fedora Update System 2016-06-30 23:15:45 UTC
openttd-1.6.1-1.fc22 grfcodec-6.0.6-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7de151b3da

Comment 4 Fedora Update System 2016-07-02 20:24:23 UTC
grfcodec-6.0.6-1.fc22, openttd-1.6.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7de151b3da

Comment 5 Fedora Update System 2016-07-02 20:30:43 UTC
grfcodec-6.0.6-1.fc24, openttd-1.6.1-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-526e5981d2

Comment 6 Fedora Update System 2016-07-02 20:55:59 UTC
grfcodec-6.0.6-1.fc23, openttd-1.6.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f619d13dbd

Comment 7 Fedora Update System 2016-07-12 02:21:10 UTC
grfcodec-6.0.6-1.fc22, openttd-1.6.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2016-07-12 02:25:13 UTC
grfcodec-6.0.6-1.fc23, openttd-1.6.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-07-12 15:07:30 UTC
grfcodec-6.0.6-1.fc24, openttd-1.6.1-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.