Bug 1342839

I'll take a looksy at this.

rpmlint looks like non-issues:

python2-pycodestyle.noarch: W: self-obsoletion python-pep8 obsoletes python-pep8
python2-pycodestyle.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python2-pycodestyle/objects.inv
python2-pycodestyle.noarch: W: file-not-utf8 /usr/share/doc/python2-pycodestyle/objects.inv
python2-pycodestyle.noarch: W: no-manual-page-for-binary pycodestyle
python3-pycodestyle.noarch: W: self-obsoletion python3-pep8 obsoletes python3-pep8



Issues:

Remove the Group tag (also, it occurs to me this is something I ought to patch fedora-review to look for)

- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 6840320 bytes in 102 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

Issues resolved. Instead of having sphinx build html docs with a custom theme, I changed it to simply build a man page.


Spec URL: https://lmacken.fedorapeople.org/rpms/python-pycodestyle.spec
SRPM URL: https://lmacken.fedorapeople.org/rpms/python-pycodestyle-2.0.0-1.fc25.src.rpm

Okay, looks good.  Approved.

The executable names do not follow the guidelines.

https://fedoraproject.org/wiki/Packaging:Python#Naming

Updated to adhere to the Python guidelines. /usr/bin/pycodestyle is now python2.

Spec URL: https://lmacken.fedorapeople.org/rpms/python-pycodestyle.spec
SRPM URL: https://lmacken.fedorapeople.org/rpms/python-pycodestyle-2.0.0-1.fc25.src.rpm

You should provide all -2, -2.7, -3, -3.5.

See http://python-rpm-porting.readthedocs.io/en/latest/tools.html#install and the following section there as well for a good idea how to do it.

John: I find your lack of good review disturbing, please follow https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

It also seems like a good idea to provide /usr/bin/pep8* symlinks for backward compatibility.

(In reply to Miro Hrončok from comment #7)
> You should provide all -2, -2.7, -3, -3.5.
> 
> See http://python-rpm-porting.readthedocs.io/en/latest/tools.html#install
> and the following section there as well for a good idea how to do it.

Thanks for the link, that's a great resource. I'll work on fixing this up at some point today.

Note that pycodestyle doesn't provide compatibility shims for the pep8 Python import API and also differs in a couple of other ways that keep it from being a drop-in replacement for the pep8 package: https://github.com/PyCQA/pycodestyle/issues/549

So rather than obsoleting/providing python-pep8 here, it may be preferable to make them parallel installable for now, and then look at making python-pep8 depend on python-pycodestyle at some point in the future.

I agree with Nick, they each (pep8 and pycodestyle) provide different executables, and therefore the `Obsoletes` and `Provides` are probably not desirable.

~ Ian (Maintainer for pycodestyle / pep8)

- removed pep8 obsoletes/provides
- provide pycodestyle-{2,2.7,3,3.5}
- use autosetup and new python build + install macros

Spec URL: https://lmacken.fedorapeople.org/rpms/python-pycodestyle.spec
SRPM URL: https://lmacken.fedorapeople.org/rpms/python-pycodestyle-2.0.0-1.fc24.src.rpm

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pycodestyle

This package have not been already builded?

(In reply to William Moreno from comment #14)
> This package have not been already builded?

nope

ping

I have an update ready of one package, that needs this. Can I proceed with building the attached SRPM?

Ping Luke?

Luke, could you please take care of importing and building this, or let others know if you need/want help with it? There are people and packages waiting for this to appear in the repos.

I've just built this in rawhide.

python-pycodestyle-2.0.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-dce2f89dec

python-pycodestyle-2.0.0-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d87d3b3103

python-pycodestyle-2.0.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4461dd7a21

python-pycodestyle-2.0.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4461dd7a21

python-pycodestyle-2.0.0-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d87d3b3103

python-pycodestyle-2.0.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-dce2f89dec

python-flake8-import-order-0.9.2-1.fc25 python-pycodestyle-2.0.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-dce2f89dec

python-flake8-import-order-0.9.2-1.fc25, python-pycodestyle-2.0.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-dce2f89dec

python-flake8-import-order-0.9.2-1.fc25, python-pycodestyle-2.0.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

python-pycodestyle-2.0.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

python-pycodestyle-2.0.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.