Bug 1343132
Summary: | Dangling symlink /etc/systemd/system/syslog.service | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jan Pazdziora <jpazdziora> | ||||||
Component: | rsyslog | Assignee: | Jiří Vymazal <jvymazal> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | unspecified | Docs Contact: | |||||||
Priority: | unspecified | ||||||||
Version: | 25 | CC: | admiller, bruno, dustymabe, jlieskov, jpazdziora, jvymazal, kevin, lkundrak, mah.darade, pvrabec, vanmeeuwen+fedora, ville.skytta, vpavlin, zbyszek, zing | ||||||
Target Milestone: | --- | Keywords: | Reopened | ||||||
Target Release: | --- | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | rsyslog-8.24.0-1.fc25 rsyslog-8.24.0-2.fc25 | Doc Type: | If docs needed, set a value | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2017-02-09 04:20:23 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Jan Pazdziora
2016-06-06 15:12:52 UTC
Well, it would be good to find out what makes this file and make it stop doing so, but I am not sure what that is. ;( Does it appear on a non container install? The file exists on non-container Fedora 23 installation. It is not owned by any package. It seems to come from: $ rpm -q --scripts systemd | grep -1 syslog # Stop-gap until rsyslog.rpm does this on its own. (This is supposed # to fail when the link already exists) ln -s /usr/lib/systemd/system/rsyslog.service /etc/systemd/system/syslog.service >/dev/null 2>&1 || : Adding a systemd maintainer here to look at why that rsyslog bit is still there. ;) Yeah, I'm not sure why systemd is providing this (it's an alias syslog.service → rsyslog.service). If anything rsyslog should have that. I'd be happy to drop it. (But note that it shouldn't cause any problems. Systemd doesn't really care where the symlink points). Does rsyslog need the syslog.service → rsyslog.service alias? If yes, let's move the symlink to rsyslog. Afterwards, we'll drop it from systemd (should not be an issue to have it in two place temporarily). If something, the symlink likely should live in /usr and not in /etc because /etc is reserved for admin's local modifications. FWIW, /usr/lib/systemd/system/syslog.socket documents that the "Best way to achieve" this would be to simply uncomment the current ";Alias=syslog.service" in rsyslog.service. No, not really. The Alias= setting only works after the unit is loaded. If nothing refers to rsyslog.service, but something wants syslog.service, it will not work. A symlink is better, if all use cases are to be supported. This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Issue still present: # for i in 23 24 25 rawhide ; do echo fedora:$i: ; docker run --rm -ti fedora:$i ls -la /etc/systemd/system/syslog.service /usr/lib/systemd/system/rsyslog.service ; donefedora:23: ls: cannot access /usr/lib/systemd/system/rsyslog.service: No such file or directory lrwxrwxrwx. 1 root root 39 Jun 20 05:17 /etc/systemd/system/syslog.service -> /usr/lib/systemd/system/rsyslog.service fedora:24: ls: cannot access '/usr/lib/systemd/system/rsyslog.service': No such file or directory lrwxrwxrwx. 1 root root 39 Aug 15 05:18 /etc/systemd/system/syslog.service -> /usr/lib/systemd/system/rsyslog.service fedora:25: ls: cannot access '/usr/lib/systemd/system/rsyslog.service': No such file or directory lrwxrwxrwx. 1 root root 39 Nov 15 20:04 /etc/systemd/system/syslog.service -> /usr/lib/systemd/system/rsyslog.service fedora:rawhide: ls: cannot access '/usr/lib/systemd/system/rsyslog.service': No such file or directory lrwxrwxrwx. 1 root root 39 Nov 7 11:00 /etc/systemd/system/syslog.service -> /usr/lib/systemd/system/rsyslog.service Created attachment 1240269 [details]
proposed patch
added a patch do do symlink in rsyslog package, it will be included in rsyslog-8.24.0, therefore you can drop it from systemd after it rolls out rsyslog-8.24.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f1200343ac The patch which adds ln -s /usr/lib/systemd/system/rsyslog.service /etc/systemd/system/syslog.service >/dev/null 2>&1 || : breaks requirements per man systemd.unit(5) which says │/etc/systemd/system │ Local configuration │ The symlink IMHO should be ln -s /usr/lib/systemd/system/rsyslog.service /usr/lib/systemd/system/syslog.service >/dev/null 2>&1 || : rsyslog-8.24.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f1200343ac Created attachment 1241167 [details]
proposed patch
edited proposed patch to conform to systemd doc After considering https://bugzilla.redhat.com/show_bug.cgi?id=1055421#c2 and systemd syslog doc: https://www.freedesktop.org/wiki/Software/systemd/syslog/ removing proposed patch entirely, leaving this to service alias (enabled in rsyslog 8.24.0) rsyslog-8.24.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. re-opening because symlink removal done in 8.24.0.1-2 rsyslog-8.24.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-83155d0a69 rsyslog-8.24.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-83155d0a69 rsyslog-8.24.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |