Bug 1343362
Summary: | Input / Output when chmoding files on NFS mount point | |||
---|---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Manikandan <mselvaga> | |
Component: | nfs | Assignee: | Manikandan <mselvaga> | |
Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
Severity: | unspecified | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 3.7.11 | CC: | bugs, jthottan, jules, lemonnier.k, ndevos, skoduri, smohan | |
Target Milestone: | --- | Keywords: | Triaged | |
Target Release: | --- | |||
Hardware: | x86_64 | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | glusterfs-3.7.12 | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | ||
Clone Of: | 1318204 | |||
: | 1343367 1343368 (view as bug list) | Environment: | ||
Last Closed: | 2016-06-28 12:19:47 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | 1318204 | |||
Bug Blocks: | 1336753, 1343367, 1343368 |
Description
Manikandan
2016-06-07 08:26:57 UTC
REVIEW: http://review.gluster.org/14659 (nfs : store sattr properly in nfs3_setattr() call) posted (#1) for review on release-3.7 by Manikandan Selvaganesh (mselvaga) REVIEW: http://review.gluster.org/14659 (nfs : store sattr properly in nfs3_setattr() call) posted (#2) for review on release-3.7 by Manikandan Selvaganesh (mselvaga) COMMIT: http://review.gluster.org/14659 committed in release-3.7 by Kaushal M (kaushal) ------ commit c04ee47d1e9847b50c459734a42681450005ee60 Author: Jiffin Tony Thottan <jthottan> Date: Mon Jun 6 18:10:09 2016 +0530 nfs : store sattr properly in nfs3_setattr() call nfs3_setattr stores the input arguments in cs->stbuf. However, inode/entry resolution code overwrites cs->stbuf after a successful resolution, thereby overwriting the input arguments with iatt values stored on backend. Hence operations like chmod/chown turns out to be a NOP. Specifically following are the functions that overwrite cs->stbuf: nfs3_fh_resolve_inode_lookup_cbk nfs3_fh_resolve_entry_lookup_cbk Since we resort to inode resolution only when inode is not found in inode table and lru limit guards the number of inodes in itable, we run into this issue only when the data set is bigger than lru limit of itable. Fix is to store input arguments in a member other than cs->stbuf. Thanks Du for suggesting the fix Backport of http://review.gluster.org/#/c/14657/ > Change-Id: I7caef48839d4f177c3557d7823fc1d35c8294939 > BUG: 1318204 > Signed-off-by: Jiffin Tony Thottan <jthottan> > Signed-off-by: Manikandan Selvaganesh <mselvaga> Change-Id: I7caef48839d4f177c3557d7823fc1d35c8294939 BUG: 1343362 Signed-off-by: Manikandan Selvaganesh <mselvaga> Reviewed-on: http://review.gluster.org/14659 Reviewed-by: jiffin tony Thottan <jthottan> Reviewed-by: Niels de Vos <ndevos> CentOS-regression: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> Reviewed-by: Raghavendra G <rgowdapp> Smoke: Gluster Build System <jenkins.org> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.12, please open a new bug report. glusterfs-3.7.12 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-devel/2016-June/049918.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |