Bug 1343370

Summary: libvirt: FTBFS in Rawhide
Product: [Fedora] Fedora Reporter: Jitka Plesnikova <jplesnik>
Component: libvirtAssignee: Libvirt Maintainers <libvirt-maint>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: agedosier, berrange, clalancette, crobinso, itamar, jtomko, laine, libvirt-maint, veillard, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-07 13:39:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1343059    

Description Jitka Plesnikova 2016-06-07 08:37:03 UTC
Description of problem:
The build libvirt-1.3.5-1.fc25 failed with following error.

checking for SYSTEMD_DAEMON... no
configure: error: You must install the libsystemd-daemon >= 0.27.1 pkg-config module to compile libvirt
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.WYgJAP (%build)
    Bad exit status from /var/tmp/rpm-tmp.WYgJAP (%build)
Child return code was: 1
EXCEPTION: [Error()]
Traceback (most recent call last):
  File "/usr/lib/python3.4/site-packages/mockbuild/trace_decorator.py", line 88, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.4/site-packages/mockbuild/util.py", line 547, in do
    raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
mockbuild.exception.Error: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps /builddir/build/SPECS/libvirt.spec

Additional info:
It is probably related to changes in the latest systemd

https://github.com/systemd/systemd/blob/master/NEWS

CHANGES WITH 230:

        * The compatibility libraries libsystemd-daemon.so,
          libsystemd-journal.so, libsystemd-id128.so, and libsystemd-login.so
          which have been deprecated since systemd-209 have been removed along
          with the corresponding pkg-config files. All symbols provided by
          those libraries are provided by libsystemd.so.

Comment 1 Ján Tomko 2016-06-07 08:45:49 UTC
Proposed patch:
https://www.redhat.com/archives/libvir-list/2016-June/msg00253.html

Comment 2 Ján Tomko 2016-06-07 08:54:49 UTC
Now pushed upstream:
commit c0bc172383c2c955394589e5808457935ae06f1d
Author:     Daniel P. Berrange <berrange>
AuthorDate: 2016-06-06 15:03:27 +0100
Commit:     Daniel P. Berrange <berrange>
CommitDate: 2016-06-07 09:37:57 +0100

    systemd: directly notify systemd instead of using sd_notify
    
    The sd_notify method is used to tell systemd when libvirtd
    has finished starting up. All it does is send a datagram
    containing the string parameter to systemd on a UNIX socket
    named in the NOTIFY_SOCKET environment variable. Rather than
    pulling in the systemd libraries for this, just code the
    notification directly in libvirt as this is a stable ABI
    from systemd's POV which explicitly allows independant
    implementations:
    
    See "Reimplementable Independently" column in the
    "$NOTIFY_SOCKET Daemon Notifications" row:
    
    https://www.freedesktop.org/wiki/Software/systemd/InterfacePortabilityAndStabilityChart/
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1314881
    
    Signed-off-by: Daniel P. Berrange <berrange>

git describe: v1.3.5-11-gc0bc172

Comment 3 Cole Robinson 2016-06-07 13:39:35 UTC
rawhide git is fixed now