Bug 1343442

Summary: The default value of 'max_anonymous_clients' is not correct
Product: Red Hat Enterprise Linux 7 Reporter: yafu <yafu>
Component: libvirtAssignee: Michal Privoznik <mprivozn>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.3CC: dyuan, fjin, mzhan, rbalakri, yanqzhan, zpeng
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-2.0.0-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-03 18:46:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description yafu 2016-06-07 11:13:31 UTC
Description of problem:
The default value of 'max_anonymous_clients' is not correct.


Version-Release number of selected component (if applicable):
libvirt-1.3.4-1.el7

How reproducible:
100%


Steps to Reproduce:
1.Configure the libvirtd.conf as below and restart libvirtd service:
  loglevel=1
  log_outpus="1:file:/var/log/libvirt/libvirtd.log"

2.Open first terminal, check the default value of 'max_anonymous_clients':
  #tailf /var/log/libvirt/libvirtd.log | grep -i  nclients_unauth_max

3.Open second termial, Connect to libvirtd:
  # virsh 
Welcome to virsh, the virtualization interactive terminal.

Type:  'help' for help with commands
       'quit' to quit

virsh # list
 Id    Name                           State
----------------------------------------------------

4.Check the output in the first terminal:
 ...
 2016-06-07 11:03:59.469+0000: 9437: debug : virNetServerCheckLimits:730 : Considering re-enabling services: nclients=1 nclients_max=5000 nclients_unauth=0 **nclients_unauth_max=20**
 ...

Actual results:
The default value of 'max_anonymous_clients' is '20'.

Expected results:
According the explanation in libvirtd.conf the default value should be '0':
#cat /etc/libvirt/libvirtd.conf
 ...
  # The maximum length of queue of accepted but not yet
  # authenticated clients. The default value is **zero**, meaning
  # the feature is disabled.
  #max_anonymous_clients = 20
  ...

Additional info:

Comment 1 Michal Privoznik 2016-06-27 08:54:01 UTC
commit 60f1f1082a635928d9310ec49ea13290e7e13929
Author:     Michal Privoznik <mprivozn>
AuthorDate: Sun Jun 26 09:44:41 2016 +0200
Commit:     Michal Privoznik <mprivozn>
CommitDate: Mon Jun 27 08:54:03 2016 +0200

    libvirtd.conf: Fix invalid default of max_anonymous_clients
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1343442
    
    When a client connects, it is placed into a queue. As soon as it
    authenticate, it is taken out of that queue and placed into a
    different one. Now, we have a setting in the daemon config file
    that allows users to control the length of the queue of yet not
    authenticated clients. By default, it has a value 20 but in the
    description to the config knob we clam it's zero.
    
    Signed-off-by: Michal Privoznik <mprivozn>

v2.0.0-rc1-27-g60f1f10

Comment 3 Fangge Jin 2016-07-11 06:19:40 UTC
Verify on build libvirt-2.0.0-2.el7.x86_64

Check the description in libvirtd.conf:

# The maximum length of queue of accepted but not yet
# authenticated clients. The default value is **20**. Set this to
# zero to turn this feature off.
#max_anonymous_clients = 20

The default value in description is updated to **20**

Comment 5 errata-xmlrpc 2016-11-03 18:46:39 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2577.html