Bug 1343580

Summary:	Review Request: perl-rdapper - Command-line RDAP client
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-rdapper-0.08-1.fc25	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-13 13:51:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2016-06-07 13:44:15 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-rdapper/perl-rdapper.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-rdapper/perl-rdapper-0.08-1.fc25.src.rpm
Description:
rdapper is a command-line client for the Registration Data Access Protocol
(RDAP), the successor protocol to WHOIS (RFC 3912). RDAP is currently being
developed by the WEIRDS IETF working group <https://tools.ietf.org/wg/weirds/>.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-06-13 12:41:11 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
No test defined
BuildRequires are ok

$ rpm -qp --requires perl-rdapper-0.08-1.fc25.noarch.rpm | sort | uniq -c
      1 /usr/bin/perl
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Getopt::Long)
      1 perl(HTTP::Request::Common)
      1 perl(IO::Socket::SSL)
      1 perl(JSON)
      1 perl(JSON::Path)
      1 perl(LWP) >= 6.00
      1 perl(LWP::Protocol::https)
      1 perl(MIME::Base64)
      1 perl(MIME::Type)
      1 perl(Mozilla::CA)
      1 perl(POSIX)
      1 perl(Pod::Usage)
      1 perl(URI)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-rdapper-0.08-1.fc25.noarch.rpm | sort | uniq -c
      1 perl-rdapper = 0.08-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-rdapper*
perl-rdapper.noarch: W: spelling-error %description -l en_US https -> HTTP
perl-rdapper.noarch: W: spelling-error %description -l en_US ietf -> diet
perl-rdapper.noarch: W: spelling-error %description -l en_US wg -> w, g, wig
perl-rdapper.noarch: W: spelling-error %description -l en_US weirds -> wards, weird, weirs
perl-rdapper.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-rdapper/COPYING
perl-rdapper.src: W: spelling-error %description -l en_US https -> HTTP
perl-rdapper.src: W: spelling-error %description -l en_US ietf -> diet
perl-rdapper.src: W: spelling-error %description -l en_US wg -> w, g, wig
perl-rdapper.src: W: spelling-error %description -l en_US weirds -> wards, weird, weirs
2 packages and 1 specfiles checked; 1 errors, 8 warnings.

The incorrect FSF address was reported to the upstream.

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2016-06-13 13:28:18 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-rdapper

Comment 3 Petr Pisar 2016-06-13 13:51:08 UTC

Thank you for the review and the repository.