Bug 1343616 (CVE-2016-4970)

Summary:	CVE-2016-4970 netty: Infinite loop vulnerability when handling renegotiation using SslProvider.OpenSsl
Product:	[Other] Security Response	Reporter:	Adam Mariš <amaris>
Component:	vulnerability	Assignee:	Red Hat Product Security <security-response-team>
Status:	CLOSED ERRATA	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	CC:	abaron, abhgupta, aileenc, alazarot, apevec, asantos, asoldano, ayoung, bbaranow, bbuckingham, bkearney, bmaxwell, brian.stansberry, cbillett, cdewolf, chazlett, chrisw, csutherl, dandread, darran.lofthouse, dhanak, dkreling, dosoudil, drieden, ecerquei, eglynn, ehelms, etirelli, fjuma, ggainey, ggaughan, gmalinko, gvarsami, hhorak, ibek, istudens, ivassile, iweiss, janstey, jason.greene, jawilson, jboss-set, jcoleman, jjoyce, jochrist, jolee, jorton, jrokos, jschatte, jschluet, jshepherd, jstastny, juwatts, jwon, kanderso, kconner, kverlaen, ldimaggi, lgao, lhh, loleary, lpeer, lsvaty, markmc, mbaluch, mburns, mgarciac, mhulan, miburman, mkolesni, mnovotny, mosmerov, msochure, msvehla, mwinkler, myarboro, nmoumoul, nobody+bgollahe, nwallace, ohudlick, omajid, pcreech, pdelbell, pgier, pgrist, pjindal, pmackay, porcelli, pslavice, rbryant, rcernich, rchan, rguimara, rnetuka, rrajasek, rstancel, rstepani, rsvoboda, rwagner, rzhang, rzima, sclewis, scohen, security-response-team, sgehwolf, slong, smaestri, soa-p-jira, spinder, tcunning, tdecacqu, theute, tiwillia, tkirby, tomckay, tom.jenkinson, twalsh, vhalbert, vtunka
Target Milestone:	---	Keywords:	Security
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	netty 4.0.37, netty 4.1.1	Doc Type:	Bug Fix
Doc Text:	An infinite-loop vulnerability was discovered in Netty's OpenSslEngine handling of renegotiation. An attacker could exploit this flaw to cause a denial of service. Note: Netty is only vulnerable if renegotiation is enabled (default setting).	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-28 19:27:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1347057, 1347058, 1347059, 1347497
Bug Blocks:	1343619, 1357951, 1357954, 1379523, 1381801, 1439275

Description Adam Mariš 2016-06-07 14:28:12 UTC

Due to a bug in handling return code from openssl native calls, the SslHandler that uses OpenSslEngine can end up in an infinite loop and eat up all CPU cycles, which may lead to DoS of the system.

This can only happen if the server has renegotiation enabled (which is set as default). Only systems using SslProvider.OpenSsl are affected, that will be true if netty-tcnative is in the classpath and openssl is installed.

If netty-tcnative is linked against boringssl, the problem does not exist, since renegotiation is not supported in boringssl.

Versions affected: Netty 4.0.0.Final - 4.0.36.Final and 4.1.0.Final

Workaround:

Users can use -Djdk.tls.rejectClientInitiatedRenegotiation=true to disable renegotiation and avoid this issue.

Comment 5 Summer Long 2016-06-17 05:08:06 UTC

Created netty tracking bugs for this issue:

Affects: fedora-all [bug 1347497]

Comment 9 Tomas Hoger 2016-06-28 11:04:18 UTC

This was fixed in netty 4.0.37 and 4.1.1:

http://netty.io/news/2016/06/07/4-0-37-Final.html
http://netty.io/news/2016/06/07/4-1-1-Final.html

Upstream bug / pull request:

https://github.com/netty/netty/pull/5364

Upstream commits:

https://github.com/netty/netty/commit/524156f164a910b8b0978d27a2c700a19cd8048f 4.0
https://github.com/netty/netty/commit/9e2c400f89c5badc39919f811179d3d42ac5257c 4.1

Comment 10 Tomas Hoger 2016-06-28 11:09:32 UTC

There are 3 netty versions in Red Hat Software Collections and Red Hat Developer Toolset:

- rh-java-common-netty and devtoolset-4-netty - both used on upstream version 4.0.28.  However, OpenSslEngine is removed from those packages, similar to netty packages in Fedora:

http://pkgs.fedoraproject.org/cgit/rpms/netty.git/tree/npn_alpn_ssl_fixes.patch

- thermostat1-netty - based on upstream version 3.6.3, which does not include OpenSslEngine, which was only added upstream in version 3.9.2:

http://netty.io/news/2014/06/11/3-9-2-Final.html

Additionally, netty-tcnative required by OpenSslEngine is not shipped as part of RHSCL or DTS.

Comment 11 Tomas Hoger 2016-06-28 11:16:52 UTC

Fedora also includes netty3 packages, using upstream version 3.9.3, and hence including OpenSslEngine.  The information above suggests only 4.0.0 and later were affected by this issue, but, based on a quick look at the code and patch, it's not obvious to me why 3.9.x are not affected.  CCing netty3 packages owner so that they can be double checked.

Comment 12 Summer Long 2016-06-28 22:21:00 UTC

ODL upstream announcement and patch: https://git.opendaylight.org/gerrit/#/c/40098/
https://wiki.opendaylight.org/view/Security_Advisories#.5BImportant.5D_CVE-2016-4970_netty:_unspecified_vulnerability_leading_to_denial_of_service

Comment 16 errata-xmlrpc 2017-04-19 16:23:26 UTC

This issue has been addressed in the following products:



Via RHSA-2017:1097 https://access.redhat.com/errata/RHSA-2017:1097

Comment 21 errata-xmlrpc 2020-07-28 15:54:06 UTC

This issue has been addressed in the following products:

  Red Hat Fuse 7.7.0

Via RHSA-2020:3192 https://access.redhat.com/errata/RHSA-2020:3192

Comment 22 Product Security DevOps Team 2020-07-28 19:27:39 UTC

This bug is now closed. Further updates for individual products will be reflected on the CVE page(s):

https://access.redhat.com/security/cve/cve-2016-4970