Bug 1343645

Summary:	livecd-iso-to-disk states "/Packages found, will copy source packages to target", but does not
Product:	[Fedora] Fedora	Reporter:	Jerry Amundson <jamundso>
Component:	livecd-tools	Assignee:	Brian Lane <bcl>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	23	CC:	adam.stokes, bcl, bruno, dhuff, jamundso, Jasper.Hartline, katzj
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	livecd-tools-23.4-1 livecd-tools-23.4-1.fc25	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-13 18:11:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jerry Amundson 2016-06-07 15:04:09 UTC

Description of problem:
livecd-iso-to-disk states "/Packages found, will copy source packages to target", but does not

Version-Release number of selected component (if applicable):
livecd-tools-23.3-1.fc23.x86_64

How reproducible:
Always

Steps to Reproduce:
1.livecd-iso-to-disk --efi --format --noverify --reset-mbr --label TRUEDEF /home/jamundson/Downloads/TrueDef-5.2-33422.iso /dev/sdc1

2.
3.

Actual results:
USB device with ISO file on it

Expected results:
USB device with /Packages copied over.

Additional info:
The "Copying $SRC to device" gets done, so maybe I will create the ISO differently.
But, the claim "/Packages found, will copy source packages to target", should not be made anyway.

Comment 1 Brian Lane 2016-06-07 17:55:38 UTC

What is this TrueDef iso you are trying to write to USB? livecd-iso-to-disk is meant to be used with Fedora/RHEL iso's and anything else is likely to confuse it.

You can try running with bash -x livecd-iso-to-disk to see what's actually happening.

Comment 2 Jerry Amundson 2016-06-08 17:53:41 UTC

Here's an example with a Fedora ISO ...

# bash -x livecd-iso-to-disk --efi /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso /dev/sdc1
+ export PATH=/sbin:/usr/sbin:/usr/lib64/qt-3.3/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin
+ PATH=/sbin:/usr/sbin:/usr/lib64/qt-3.3/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/root/bin
++ id -u
+ '[' 0 '!=' 0 ']'
+ set -e
+ set -o pipefail
+ trap exitclean EXIT
+ shopt -s extglob
+ cryptedhome=1
+ keephome=1
+ homesizemb=0
+ swapsizemb=0
+ overlaysizemb=0
+ srctype=
+ imgtype=
+ packages=
+ LIVEOS=LiveOS
+ HOMEFILE=home.img
+ updates=
+ ks=
+ label=LIVE
+ true
+ case $1 in
+ efi=1
+ shift
+ true
+ case $1 in
+ break
+ '[' 2 -ne 2 ']'
++ readlink -f /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso
+ SRC=/home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso
++ readlink -f /dev/sdc1
+ TGTDEV=/dev/sdc1
+ '[' -z /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso ']'
+ '[' '!' -b /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso -a '!' -f /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso ']'
+ '[' -z /dev/sdc1 ']'
+ '[' '!' -b /dev/sdc1 ']'
+ '[' -z '' ']'
+ echo 'Verifying image...'
Verifying image...
+ checkisomd5 --verbose /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso
/home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso:   1cd120922a791d03e829392a2b6b2107
Fragment sums: fba28f6826a9387e92a28d3eb8b199a8ac73726f57c8d7ed6eaff6bed1ac
Fragment count: 20
Supported ISO: no
Press [Esc] to abort check.
Checking: 100.0%

The media check is complete, the result is: PASS.

It is OK to use this media.
+ checkMounted /dev/sdc1
+ dev=/dev/sdc1
+ grep -q '^/dev/sdc1 ' /proc/mounts
+ grep -q '^/dev/sdc1 ' /proc/swaps
++ mktemp -d /media/srctmp.XXXXXX
+ SRCMNT=/media/srctmp.eTtAbi
+ '[' -b /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso ']'
+ '[' -f /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso ']'
+ mount -o loop,ro /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso /media/srctmp.eTtAbi
+ detectsrctype
+ [[ -e /media/srctmp.eTtAbi/Packages ]]
+ echo '/Packages found, will copy source packages to target'
/Packages found, will copy source packages to target
+ packages=1
+ [[ -e /media/srctmp.eTtAbi/LiveOS/squashfs.img ]]
+ '[' -e /media/srctmp.eTtAbi/images/install.img -o -e /media/srctmp.eTtAbi/isolinux/initrd.img ']'
+ '[' -n 1 ']'
+ srctype=installer
+ imgtype=install
+ '[' '!' -e /media/srctmp.eTtAbi/images/install.img ']'
+ return
+ '[' -n '' -a -z '' ']'
+ checkFilesystem /dev/sdc1
+ dev=/dev/sdc1
++ /sbin/blkid -s TYPE -o value /dev/sdc1
+ TGTFS=vfat
+ '[' vfat '!=' vfat ']'
+ '[' vfat = ext2 -o vfat = ext3 -o vfat = ext4 ']'
++ /sbin/blkid -s LABEL -o value /dev/sdc1
+ TGTLABEL=LIVE
+ '[' LIVE '!=' LIVE ']'
++ /sbin/blkid -s UUID -o value /dev/sdc1
+ TGTUUID=2C6E-FC59
+ '[' -n 2C6E-FC59 ']'
+ TGTLABEL=UUID=2C6E-FC59
+ '[' vfat = vfat -o vfat = msdos ']'
+ mountopts='-o shortname=winnt,umask=0077'
+ '[' -n 1 ']'
+ checkGPT /dev/sdc1
+ dev=/dev/sdc1
+ getdisk /dev/sdc1
+ DEV=/dev/sdc1
+ isdevloop /dev/sdc1
+ '[' x/dev/sdc1 '!=' x/dev/sdc1 ']'
++ udevadm info -q path -n /dev/sdc1
+ p=/devices/pci0000:00/0000:00:14.0/usb3/3-8/3-8:1.0/host6/target6:0:0/6:0:0:0/block/sdc/sdc1
+ '[' 0 -gt 0 ']'
+ '[' -e /sys//devices/pci0000:00/0000:00:14.0/usb3/3-8/3-8:1.0/host6/target6:0:0/6:0:0:0/block/sdc/sdc1/device ']'
+++ readlink -f /sys//devices/pci0000:00/0000:00:14.0/usb3/3-8/3-8:1.0/host6/target6:0:0/6:0:0:0/block/sdc/sdc1/../
++ basename /sys/devices/pci0000:00/0000:00:14.0/usb3/3-8/3-8:1.0/host6/target6:0:0/6:0:0:0/block/sdc
+ device=sdc
+ '[' -z sdc -o '!' -e /sys/block/sdc -o '!' -e /dev/sdc ']'
+ device=/dev/sdc
++ basename /devices/pci0000:00/0000:00:14.0/usb3/3-8/3-8:1.0/host6/target6:0:0/6:0:0:0/block/sdc/sdc1
+ p=/dev/sdc1
+ p=1
+ partnum=1
++ LC_ALL=C
++ /sbin/parted -s -m /dev/sdc p
++ grep -ic :gpt:
+ '[' 1 -eq 0 ']'
++ LC_ALL=C
++ /sbin/parted --script -m /dev/sdc print
++ grep '^1:'
+ partinfo='1:1049kB:8015MB:8014MB:fat32:EFI System Partition:legacy_boot, msftdata;'
++ echo 1:1049kB:8015MB:8014MB:fat32:EFI System Partition:legacy_boot, 'msftdata;'
++ cut -d : -f 6
+ volname='EFI System Partition'
++ echo 1:1049kB:8015MB:8014MB:fat32:EFI System Partition:legacy_boot, 'msftdata;'
++ cut -d : -f 7
+ flags='legacy_boot, msftdata;'
+ '[' 'EFI System Partition' '!=' 'EFI System Partition' ']'
++ echo legacy_boot, 'msftdata;'
++ grep -c boot
+ '[' 1 = 0 ']'
+ checkSyslinuxVersion
+ '[' '!' -x /usr/bin/syslinux ']'
+ check=($(syslinux --version 2>&1))
++ syslinux --version
+ [[ syslinux != syslinux ]]
+ '[' -n '' ']'
+ SYSLINUXPATH=syslinux
+ '[' -z 1 ']'
+ '[' -n '' ']'
+ checkMBR /dev/sdc1
+ isdevloop /dev/sdc1
+ '[' x/dev/sdc1 '!=' x/dev/sdc1 ']'
+ getdisk /dev/sdc1
+ DEV=/dev/sdc1
+ isdevloop /dev/sdc1
+ '[' x/dev/sdc1 '!=' x/dev/sdc1 ']'
++ udevadm info -q path -n /dev/sdc1
+ p=/devices/pci0000:00/0000:00:14.0/usb3/3-8/3-8:1.0/host6/target6:0:0/6:0:0:0/block/sdc/sdc1
+ '[' 0 -gt 0 ']'
+ '[' -e /sys//devices/pci0000:00/0000:00:14.0/usb3/3-8/3-8:1.0/host6/target6:0:0/6:0:0:0/block/sdc/sdc1/device ']'
+++ readlink -f /sys//devices/pci0000:00/0000:00:14.0/usb3/3-8/3-8:1.0/host6/target6:0:0/6:0:0:0/block/sdc/sdc1/../
++ basename /sys/devices/pci0000:00/0000:00:14.0/usb3/3-8/3-8:1.0/host6/target6:0:0/6:0:0:0/block/sdc
+ device=sdc
+ '[' -z sdc -o '!' -e /sys/block/sdc -o '!' -e /dev/sdc ']'
+ device=/dev/sdc
++ basename /devices/pci0000:00/0000:00:14.0/usb3/3-8/3-8:1.0/host6/target6:0:0/6:0:0:0/block/sdc/sdc1
+ p=/dev/sdc1
+ p=1
+ partnum=1
++ mktemp /tmp/bs.XXXXXX
+ bs=/tmp/bs.30LMb9
+ dd if=/dev/sdc of=/tmp/bs.30LMb9 bs=512 count=1
++ hexdump -n 2 /tmp/bs.30LMb9
++ head -n 1
++ awk '{print $2;}'
+ mbrword=c033
+ rm -f /tmp/bs.30LMb9
+ '[' c033 = 0000 ']'
+ return 0
+ '[' 0 -gt 0 ']'
+ '[' 0 -gt 0 -a vfat = vfat ']'
+ '[' 0 -gt 0 -a vfat = vfat ']'
++ mktemp -d /media/tgttmp.XXXXXX
+ TGTMNT=/media/tgttmp.m2JRMx
+ mount -o shortname=winnt,umask=0077 /dev/sdc1 /media/tgttmp.m2JRMx
+ trap exitclean SIGINT SIGTERM
+ '[' -f /media/tgttmp.m2JRMx/LiveOS/home.img -a -n 1 -a 0 -gt 0 ']'
+ '[' -n 1 ']'
+ '[' -d /media/srctmp.eTtAbi/EFI/BOOT ']'
+ EFI_BOOT=/EFI/BOOT
+ [[ -d /media/tgttmp.m2JRMx/LiveOS ]]
+ tbd=0
+ [[ live == installer ]]
+ [[ -n '' ]]
+ [[ live == installer ]]
++ df -B 1M --total /dev/sdc1
++ awk '/^total/ {print $4;}'
+ freespace=4343
+ [[ live == installer ]]
+ '[' installer = installer ']'
+ '[' install = install ']'
+ imgpath=images/install.img
++ du -s -B 1M /media/srctmp.eTtAbi/images/install.img
++ awk '{print $1;}'
+ installimgsize=331
+ tbd=0
+ '[' -e /media/tgttmp.m2JRMx/images/install.img ']'
++ du -s -B 1M /media/tgttmp.m2JRMx/images/install.img
++ awk '{print $1;}'
+ tbd=331
++ basename /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso
+ '[' -e /media/tgttmp.m2JRMx/Fedora-Server-DVD-x86_64-23.iso ']'
++ awk '{print $1;}'
+++ basename /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso
++ du -s -B 1M /media/tgttmp.m2JRMx/Fedora-Server-DVD-x86_64-23.iso
+ tbd=2381
+ echo 'Size of images/install.img: 331'
Size of images/install.img: 331
+ echo 'Available space: 6724'
Available space: 6724
+ ((  installimgsize > ((freespace + tbd))  ))
+ '[' -z '' ']'
+ '[' installer = live ']'
+ '[' '!' -d /media/tgttmp.m2JRMx/syslinux ']'
+ '[' -n 1 -a '!' -d /media/tgttmp.m2JRMx/EFI/BOOT ']'
+ '[' installer = live -a -z '' ']'
+ [[ -d /media/srctmp.eTtAbi/isolinux/ ]]
+ cp /media/srctmp.eTtAbi/isolinux/boot.cat /media/srctmp.eTtAbi/isolinux/boot.msg /media/srctmp.eTtAbi/isolinux/grub.conf /media/srctmp.eTtAbi/isolinux/initrd.img /media/srctmp.eTtAbi/isolinux/isolinux.bin /media/srctmp.eTtAbi/isolinux/isolinux.cfg /media/srctmp.eTtAbi/isolinux/ldlinux.c32 /media/srctmp.eTtAbi/isolinux/libcom32.c32 /media/srctmp.eTtAbi/isolinux/libutil.c32 /media/srctmp.eTtAbi/isolinux/memtest /media/srctmp.eTtAbi/isolinux/splash.png /media/srctmp.eTtAbi/isolinux/TRANS.TBL /media/srctmp.eTtAbi/isolinux/vesamenu.c32 /media/srctmp.eTtAbi/isolinux/vmlinuz /media/tgttmp.m2JRMx/syslinux
+ BOOTCONFIG=/media/tgttmp.m2JRMx/syslinux/isolinux.cfg
+ BOOTCONFIG_EFI=
+ '[' -n 1 ']'
+ echo 'Setting up /EFI/BOOT'
Setting up /EFI/BOOT
+ cp -r /media/srctmp.eTtAbi/EFI/BOOT/BOOTX64.EFI /media/srctmp.eTtAbi/EFI/BOOT/fonts /media/srctmp.eTtAbi/EFI/BOOT/grub.cfg /media/srctmp.eTtAbi/EFI/BOOT/grubx64.efi /media/srctmp.eTtAbi/EFI/BOOT/MokManager.efi /media/srctmp.eTtAbi/EFI/BOOT/TRANS.TBL /media/tgttmp.m2JRMx/EFI/BOOT
+ '[' -e /media/tgttmp.m2JRMx/EFI/BOOT/grub.cfg ']'
+ BOOTCONFIG_EFI=/media/tgttmp.m2JRMx/EFI/BOOT/grub.cfg
+ rm -f /media/tgttmp.m2JRMx/EFI/BOOT/grub.conf
++ nocase_path '/media/tgttmp.m2JRMx/EFI/BOOT/boot*efi'
++ local ret=0
++ shopt -s nocaseglob
++ '[' -e '/media/tgttmp.m2JRMx/EFI/BOOT/boot*efi' ']'
++ ret=1
++ echo /media/tgttmp.m2JRMx/EFI/BOOT/BOOTX64.EFI
++ shopt -u nocaseglob
++ return 1
+ '[' '!' -f /media/tgttmp.m2JRMx/EFI/BOOT/BOOTX64.EFI ']'
+ '[' -z '' -a '(' installer = installer -o installer = netinst ')' ']'
+ echo 'Copying DVD image to target device.'
Copying DVD image to target device.
+ mkdir -p /media/tgttmp.m2JRMx/images/
+ '[' install = install ']'
+ for img in install.img updates.img product.img
+ '[' -e /media/srctmp.eTtAbi/images/install.img ']'
+ copyFile /media/srctmp.eTtAbi/images/install.img /media/tgttmp.m2JRMx/images/install.img
+ '[' -x /usr/bin/rsync ']'
+ rsync --inplace -P /media/srctmp.eTtAbi/images/install.img /media/tgttmp.m2JRMx/images/install.img
install.img
    346,673,152 100%  458.50MB/s    0:00:00 (xfr#1, to-chk=0/1)
+ return
+ for img in install.img updates.img product.img
+ '[' -e /media/srctmp.eTtAbi/images/updates.img ']'
+ for img in install.img updates.img product.img
+ '[' -e /media/srctmp.eTtAbi/images/product.img ']'
+ copyFile /media/srctmp.eTtAbi/images/product.img /media/tgttmp.m2JRMx/images/product.img
+ '[' -x /usr/bin/rsync ']'
+ rsync --inplace -P /media/srctmp.eTtAbi/images/product.img /media/tgttmp.m2JRMx/images/product.img
product.img
        858,344 100%  393.67MB/s    0:00:00 (xfr#1, to-chk=0/1)
+ return
+ '[' -n 1 -a -z '' ']'
+ '[' installer '!=' live ']'
+ echo 'Copying /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso to device'
Copying /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso to device
+ copyFile /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso /media/tgttmp.m2JRMx/
+ '[' -x /usr/bin/rsync ']'
+ rsync --inplace -P /home/jamundson/Downloads/Fedora-Server-DVD-x86_64-23.iso /media/tgttmp.m2JRMx/
Fedora-Server-DVD-x86_64-23.iso
  2,149,580,800 100%   66.91MB/s    0:00:30 (xfr#1, to-chk=0/1)
+ return
+ sed -i -e 's;initrd.img;initrd.img inst.repo=hd:UUID=2C6E-FC59:/;g' /media/tgttmp.m2JRMx/syslinux/isolinux.cfg
+ '[' -n 1 ']'
+ sed -i -e 's;vmlinuz;vmlinuz inst.repo=hd:UUID=2C6E-FC59:/;g' /media/tgttmp.m2JRMx/EFI/BOOT/grub.cfg
+ echo 'Waiting for device to finish writing'
Waiting for device to finish writing
+ sync
+ '[' installer = live ']'
+ '[' -n '' ']'
+ '[' -n '' ']'
+ echo 'Updating boot config file'
Updating boot config file
+ sed -i -e 's/CDLABEL=[^ ]*/UUID=2C6E-FC59/' -e 's/rootfstype=[^ ]*/rootfstype=vfat/' -e 's/LABEL=[^ :]*/UUID=2C6E-FC59/' /media/tgttmp.m2JRMx/syslinux/isolinux.cfg /media/tgttmp.m2JRMx/EFI/BOOT/grub.cfg
+ '[' -n '' ']'
+ '[' LiveOS '!=' LiveOS ']'
+ '[' -n 1 ']'
+ sed -i -e 's;/isolinux/;/syslinux/;g' /media/tgttmp.m2JRMx/EFI/BOOT/grub.cfg
+ sed -i -e 's;/images/pxeboot/;/syslinux/;g' /media/tgttmp.m2JRMx/EFI/BOOT/grub.cfg
+ sed -i -e 's;findiso;;g' /media/tgttmp.m2JRMx/EFI/BOOT/grub.cfg
+ '[' installer '!=' live ']'
+ '[' install '!=' install ']'
+ '[' -n '' ']'
+ '[' -n '' ']'
+ '[' 0 -gt 0 ']'
+ '[' 0 -gt 0 -a -z '' ']'
+ '[' 0 -gt 0 -a -z '' ']'
+ '[' -n '' ']'
+ '[' -z '' ']'
+ echo 'Installing boot loader'
Installing boot loader
+ '[' -n 1 ']'
+ '[' -f /media/tgttmp.m2JRMx/EFI/BOOT/BOOT.conf ']'
+ '[' -f /media/tgttmp.m2JRMx/syslinux/vesamenu.c32 -a -f /usr/share/syslinux/vesamenu.c32 ']'
+ cp /usr/share/syslinux/vesamenu.c32 /media/tgttmp.m2JRMx/syslinux/vesamenu.c32
+ for f in ldlinux.c32 libcom32.c32 libutil.c32
+ '[' -f /usr/share/syslinux/ldlinux.c32 ']'
+ cp /usr/share/syslinux/ldlinux.c32 /media/tgttmp.m2JRMx/syslinux/ldlinux.c32
+ for f in ldlinux.c32 libcom32.c32 libutil.c32
+ '[' -f /usr/share/syslinux/libcom32.c32 ']'
+ cp /usr/share/syslinux/libcom32.c32 /media/tgttmp.m2JRMx/syslinux/libcom32.c32
+ for f in ldlinux.c32 libcom32.c32 libutil.c32
+ '[' -f /usr/share/syslinux/libutil.c32 ']'
+ cp /usr/share/syslinux/libutil.c32 /media/tgttmp.m2JRMx/syslinux/libutil.c32
+ '[' vfat == vfat -o vfat == msdos ']'
+ mv /media/tgttmp.m2JRMx/syslinux/isolinux.cfg /media/tgttmp.m2JRMx/syslinux/syslinux.cfg
+ '[' -f /media/tgttmp.m2JRMx/syslinux/ldlinux.sys ']'
+ rm -f /media/tgttmp.m2JRMx/syslinux/ldlinux.sys
+ cleanup
+ sleep 2
+ '[' -d /media/srctmp.eTtAbi ']'
+ umount /media/srctmp.eTtAbi
+ rmdir /media/srctmp.eTtAbi
+ '[' -d /media/tgttmp.m2JRMx ']'
+ umount /media/tgttmp.m2JRMx
+ rmdir /media/tgttmp.m2JRMx
+ '[' -n syslinux ']'
+ syslinux -d syslinux /dev/sdc1
+ echo 'Target device is now set up with a Live image!'
Target device is now set up with a Live image!
+ exitclean
+ RETVAL=0
+ '[' -d /media/srctmp.eTtAbi ']'
+ '[' -d /media/tgttmp.m2JRMx ']'
+ exit 0

Comment 3 Brian Lane 2016-06-09 00:48:58 UTC

https://github.com/rhinstaller/livecd-tools/pull/27

Comment 4 Fedora Update System 2016-08-26 23:00:36 UTC

livecd-tools-23.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5e40d80b1c

Comment 5 Fedora Update System 2016-08-27 12:52:03 UTC

livecd-tools-23.4-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5e40d80b1c

Comment 6 Fedora Update System 2016-09-13 18:11:26 UTC

livecd-tools-23.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.