Bug 1343659

Summary:	Check all checkbox for VMs/Instances does not work correctly
Product:	Red Hat CloudForms Management Engine	Reporter:	Pavol Kotvan <pakotvan>
Component:	UI - OPS	Assignee:	Martin Hradil <mhradil>
Status:	CLOSED ERRATA	QA Contact:	Matouš Mojžíš <mmojzis>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.6.0	CC:	hkataria, jhardy, mmojzis, mpovolny, obarenbo, simaishi
Target Milestone:	GA
Target Release:	5.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	ui:ownership:vm
Fixed In Version:	5.7.0.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-04 12:55:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:

Description Pavol Kotvan 2016-06-07 15:34:10 UTC

Description of problem:
Selecting all VMs/Instances which were selected by "Check All" checkbox does not work correctly. Instances are visually selected, but when user wants to perform some action on selected list of items, it seems that action can be performed only on those items which were selected by "mouse click".

Version-Release number of selected component (if applicable):
5.6.0.9-rc2.20160531154046_b4e2f6d

How reproducible:
always

Steps to Reproduce:
1. Add VMWare Infra or RHOS Cloud provider and refresh them
2. Navigate to: 
   Compute -> Clouds -> Instances 
   or 
   Compute -> Infrastructure -> VMs
3. Select first instance/VM from the list
4. Select "Check All" checkbox to select all instances/VMs from the list 
5. Click on Configuration -> Set Ownership

Actual results:
Only objects which were selected by mouse click are displayed in "Affected Items" list. Those which were selected by "Check All" checkbox are not displayed.

Expected results:
e.g. ownership of all VMs/Instances in the list can be changed without selecting every item by clicking on it.

Additional info:
There is something wrong with "Check All" checkbox. Click on Configuration -> Compare selected items while all items in the list were selected by checkbox, will display flash error message:
At least 2 Vm Clouds must be selected for Compare

Comment 2 CFME Bot 2016-08-09 16:25:58 UTC

https://github.com/ManageIQ/manageiq/pull/10337

Comment 3 CFME Bot 2016-08-18 13:05:52 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/76bbf4c6c30feb3dfe0f6cb15bba87fb6338c597

commit 76bbf4c6c30feb3dfe0f6cb15bba87fb6338c597
Author:     Martin Hradil <mhradil>
AuthorDate: Tue Aug 9 16:21:10 2016 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Wed Aug 17 08:48:51 2016 +0000

    Convert every onclick on checkboxes to onchange
    
    This is so that checkbox handlers do the correct thing even when the checkbox was checked by keyboard, etc.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1343659

 app/assets/javascripts/automate_import_export.js               | 2 +-
 app/assets/javascripts/miq_grid.js                             | 4 ++--
 app/assets/javascripts/miq_ujs_bindings.js                     | 2 +-
 app/views/layouts/_ae_tree_select.html.haml                    | 2 +-
 app/views/layouts/_drift_history.html.haml                     | 2 +-
 app/views/layouts/_list_grid.html.haml                         | 2 +-
 app/views/layouts/gtl/_grid.html.haml                          | 2 +-
 app/views/layouts/gtl/_list.html.haml                          | 2 +-
 app/views/layouts/gtl/_tile.html.haml                          | 2 +-
 app/views/miq_ae_customization/_dialog_import_export.html.haml | 2 +-
 app/views/ops/_settings_cu_collection_tab.html.haml            | 5 ++---
 app/views/ops/rhn/_server_table.html.haml                      | 2 +-
 app/views/report/_export_widgets.html.haml                     | 2 +-
 app/views/shared/_master_toggle.html.haml                      | 2 +-
 app/views/vm_common/_vmtree.html.haml                          | 2 +-
 15 files changed, 17 insertions(+), 18 deletions(-)

Comment 4 CFME Bot 2016-08-18 13:05:57 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/461c2ea4c1427da2e9ec04f8f2f5be773e91baee

commit 461c2ea4c1427da2e9ec04f8f2f5be773e91baee
Author:     Martin Hradil <mhradil>
AuthorDate: Wed Aug 17 08:29:21 2016 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Wed Aug 17 16:55:11 2016 +0000

    Checkboxes - always trigger a change event when setting checked
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1343659

 app/assets/javascripts/dialog_field_refresh.js                |  2 +-
 app/assets/javascripts/miq_application.js                     | 10 +++++++---
 app/assets/javascripts/miq_grid.js                            | 11 ++++++-----
 app/assets/javascripts/miq_list_grid.js                       |  8 ++++----
 app/helpers/js_helper.rb                                      |  2 +-
 .../miq_ae_customization/_dialog_import_export.html.haml      |  4 +++-
 app/views/report/_export_widgets.html.haml                    |  5 +++--
 spec/helpers/js_helper_spec.rb                                |  2 +-
 8 files changed, 26 insertions(+), 18 deletions(-)

Comment 5 Matouš Mojžíš 2016-10-05 09:20:13 UTC

Verified in 5.7.0.3. After selecting one VM and then check all check all checkbox are all VMs affected.

Comment 7 errata-xmlrpc 2017-01-04 12:55:37 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0012.html