Bug 1343838

Summary:	Implement API to get page aligned iobufs in iobuf.c
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	core	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1351024 1351025 (view as bug list)		Environment:
Last Closed:	2017-03-27 18:14:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1351024, 1351025

Description Krutika Dhananjay 2016-06-08 07:15:13 UTC

Description of problem:

One of the consumers of a page aligned buffer would be posix's readv fop on O_DIRECT fds. Today the way it works is by getting a page-aligned buffer through calloc, pread()ing into this buffer and then copying its contents into a newly created iobuf's ptr. This results in an extra memcpy() which can be avoided if we could implement an api that would return an iobuf whose ptr is mem-aligned. That way the iobuf->ptr can be directly passed to sys_preadv() as a parameter by posix translator.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-06-08 11:16:33 UTC

REVIEW: http://review.gluster.org/14672 (libglusterfs: Implement API that provides page-aligned iobufs) posted (#1) for review on master by Krutika Dhananjay (kdhananj)

Comment 2 Vijay Bellur 2016-06-09 02:33:49 UTC

REVIEW: http://review.gluster.org/14672 (libglusterfs: Implement API that provides page-aligned iobufs) posted (#2) for review on master by Krutika Dhananjay (kdhananj)

Comment 3 Vijay Bellur 2016-06-09 09:34:35 UTC

REVIEW: http://review.gluster.org/14672 (libglusterfs: Implement API that provides page-aligned iobufs) posted (#3) for review on master by Krutika Dhananjay (kdhananj)

Comment 4 Vijay Bellur 2016-06-28 21:52:46 UTC

COMMIT: http://review.gluster.org/14672 committed in master by Jeff Darcy (jdarcy) 
------
commit 1e60f9746cf7cb8ce34e2b1572410c39b11d7664
Author: Krutika Dhananjay <kdhananj>
Date:   Tue Jun 7 16:27:34 2016 +0530

    libglusterfs: Implement API that provides page-aligned iobufs
    
    One of the consumers of a page aligned buffer would be posix's
    readv fop on O_DIRECT fds. Today the way it works is by getting
    a page-aligned buffer through calloc, pread()ing into this buffer
    and then copying its contents into a newly created iobuf's ptr.
    This results in an extra memcpy() which can be avoided if we could
    implement an api that would return an iobuf whose ptr is
    page-aligned. That way the iobuf->ptr can be directly passed to
    sys_pread() as a parameter by posix translator.
    
    Change-Id: I385139bc6ee309fc501034b3af8f7814fab8cd65
    BUG: 1343838
    Signed-off-by: Krutika Dhananjay <kdhananj>
    Reviewed-on: http://review.gluster.org/14672
    CentOS-regression: Gluster Build System <jenkins.org>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Zhou Zhengping <johnzzpcrystal>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 5 Shyamsundar 2017-03-27 18:14:00 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/