Bug 1343901

Summary:	Fix websocket proxy for python-websockify 0.8.0
Product:	[oVirt] ovirt-engine	Reporter:	Vinzenz Feenstra [evilissimo] <vfeenstr>
Component:	WebSocket Proxy	Assignee:	Vinzenz Feenstra [evilissimo] <vfeenstr>
WebSocket Proxy sub component:	General	QA Contact:	sefi litmanovich <slitmano>
Status:	CLOSED CURRENTRELEASE	Docs Contact:
Severity:	high
Priority:	medium	CC:	gklein, michal.skrivanek, mperina
Version:	3.6.3.3	Flags:	michal.skrivanek: ovirt-4.0.0? rule-engine: planning_ack+ michal.skrivanek: devel_ack+ rule-engine: testing_ack+
Target Milestone:	ovirt-4.0.0-rc
Target Release:	4.0.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: python-websockify in version 0.8.0 broke the API Consequence: The ovirt websocket proxy stops working Fix: We added a workaround to the websocketproxy code to detect this API breakage and handle it accordingly Result: ovirt websocket proxy is functional with python-websockify 0.6.0 and 0.8.0	Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-12 14:06:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vinzenz Feenstra [evilissimo] 2016-06-08 09:38:40 UTC

Description of problem:

The upgrade of python-websockify 0.8.0 has broken the API

ovirt websocket proxy should keep working with python-websockify 0.6.0 and 0.8.0

Comment 1 Michal Skrivanek 2016-06-08 10:29:51 UTC

targeting 4.0 GA just because websocket update is already available in centos and you would have to explicitly downgrade that package to make proxy work

Comment 2 Martin Perina 2016-06-10 14:58:44 UTC

Setting target release to 4.0.0 as it's included in today's 4.0.4 build

Comment 3 sefi litmanovich 2016-08-08 09:12:31 UTC

Verified with rhevm-4.0.2.4-0.1.el7ev.noarch, and websocket proxy installed on engine host with version: python-websockify-0.8.0-1.el7.noarch

Started a console with noVnc, worked fine as expected.