Bug 1344412

Summary:	Vertical navigation incorrectly shows non-clickable arrows, also shows clickable arrow instead of pin
Product:	Red Hat CloudForms Management Engine	Reporter:	Eric Winchell <ewinchel>
Component:	UI - OPS	Assignee:	Dávid Halász <dhalasz>
Status:	CLOSED ERRATA	QA Contact:	Matouš Mojžíš <mmojzis>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.6.0	CC:	cpelland, dclarizi, hkataria, jhardy, mmojzis, mpovolny, obarenbo, simaishi
Target Milestone:	GA
Target Release:	5.6.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	5.6.0.11	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-29 16:07:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eric Winchell 2016-06-09 15:36:55 UTC

Description of problem:

Secondary and Tertiary Nav shows a left arrow that can not be clicked to collapse the nav on an inactive menu item. No icon should be visible when nav can not be collapsed. Also, should be displaying a pin rather than an arrow when it can be collapsed.

Version-Release number of selected component (if applicable):


How reproducible:

100%

Steps to Reproduce:
1. Open secondary nav menu that is not active 
2. Attempt to click left-facing arrow in menu header
3. 

Actual results:

Nothing happens

Expected results:

No icon should be displayed when menu item is not active

Additional info:

Comment 4 CFME Bot 2016-06-13 18:28:08 UTC

New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/740f8d8ae65b9ff83f37c7d9557aed80eb170808

commit 740f8d8ae65b9ff83f37c7d9557aed80eb170808
Author:     Dávid Halász <dhalasz>
AuthorDate: Thu Jun 9 10:51:58 2016 -0400
Commit:     Dávid Halász <dhalasz>
CommitDate: Thu Jun 9 11:41:26 2016 -0400

    Update markup for pin/unpin icons in the tertiary navigation
    
    The fontawesome classes are obsolete and can cause issues in the future.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1344412

 app/views/layouts/_vertical_navbar.html.haml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 5 CFME Bot 2016-06-15 12:49:29 UTC

https://github.com/ManageIQ/manageiq/pull/9133

Comment 6 Matouš Mojžíš 2016-06-16 17:08:43 UTC

Can somebody provide me a screenshot with these non-clickable arrows and clickable arrows instead of pin?

Comment 8 Matouš Mojžíš 2016-06-17 14:36:18 UTC

Yes, I can see there are no arrows and only pins.
But pins are only visible in menu item activelly used.
I can't pin different menu items.
When I want to pin different items I first must select them (make active) and then pin appears on that item.
Is it designed to work like this?

Comment 9 Eric Winchell 2016-06-17 15:09:31 UTC

That's correct. Only the active menu items can be pinned.

Comment 10 Matouš Mojžíš 2016-06-17 15:12:20 UTC

Okay, verified in 5.6.0.11. It's displayed as it should.

Comment 11 CFME Bot 2016-06-20 12:08:04 UTC

https://github.com/ManageIQ/manageiq/pull/7620

Comment 13 errata-xmlrpc 2016-06-29 16:07:18 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348