Bug 1344712

Summary: pcs resource create command fails when duplicate parameter is used
Product: Red Hat Enterprise Linux 7 Reporter: Roman Bednář <rbednar>
Component: pcsAssignee: Ivan Devat <idevat>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: low Docs Contact:
Priority: medium    
Version: 7.3CC: cfeist, cluster-maint, idevat, omular, rsteiger, tojeline
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Fixed In Version: pcs-0.9.156-1.el7 Doc Type: Bug Fix
Doc Text:
Cause: The user enters the same option multiple times with different values (by a mistake). Pcs omits all earlier values and uses the last value. Consequence: The user is not notified that entered ambiguous option value. The content of cib can be different than what the user wanted. Fix: Pcs requires a unambiguous option value. Result: The user cannot successfully enter unambiguous option value.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 18:22:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Description Flags
proposed fix (part1)
proposed fix (part2) none

Description Roman Bednář 2016-06-10 13:06:06 UTC
Description of problem:
resource creation fails when used with duplicate arguments, see reproducer.

How reproducible:

Steps to Reproduce:
1. setup pcs
2. #pcs resource create dummy dummy aaa=bbb aaa=ccc --force

Actual results:
command fails and CIB is dumped

Expected results:
error message or override of the previous(duplicate) parameters

Additional info:
applies to all resources

Comment 2 Ivan Devat 2017-02-01 15:34:40 UTC
Created attachment 1246692 [details]
proposed fix (part1)

Comment 3 Ivan Devat 2017-02-01 15:36:01 UTC
Created attachment 1246693 [details]
proposed fix (part2)

Tests are in the patch.

Comment 4 Ivan Devat 2017-02-20 07:55:34 UTC
After Fix:

[vm-rhel72-1 ~] $ rpm -q pcs

[vm-rhel72-1 ~] $ pcs resource create dummy ocf:heartbeat:Dummy aaa=bbb aaa=ccc
Error: duplicate option 'aaa' with different values 'bbb' and 'ccc'

[vm-rhel72-1 ~] $ pcs resource create dummy ocf:heartbeat:Dummy aaa=bbb aaa=ccc --force
Error: duplicate option 'aaa' with different values 'bbb' and 'ccc'

Comment 8 errata-xmlrpc 2017-08-01 18:22:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.