Bug 1345809

Summary: virt-customize --truncate-recursive should give an error message when specifying a no-existing path
Product: Red Hat Enterprise Linux 7 Reporter: Xianghua Chen <xchen>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.3CC: ptoscano, wshi
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libguestfs-1.32.5-4.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-03 18:01:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
log.truncate-recursive none

Description Xianghua Chen 2016-06-13 08:52:56 UTC
Created attachment 1167288 [details]
log.truncate-recursive

Description of problem:
virt-customize --truncate-recursive should give an error message when specifying a no-existing path.
You can see the full log with -v -x in the attachment: log.truncate-recursive.

Version-Release number of selected component (if applicable):
libguestfs-1.32.5-3.el7.x86_64

How reproducible:
Always

Steps to Reproduce:
1.  Prepare an rhel7 image:  RHEL-Server-7.2-64-hvm.raw
2. Use  --truncate-recursive to truncate a no-existing path
# virt-customize -a  RHEL-Server-7.2-64-hvm.raw --truncate-recursive /home/noexist
[   0.0] Examining the guest ...
[   3.7] Setting a random seed
[   3.7] Recursively truncating: /home/noexist
[   3.9] Finishing off


Actual results:
It finished with no error.

Expected results:
It should prompt an error looks like:
No such path or directory

Additional info:

Comment 1 Richard W.M. Jones 2016-06-13 10:33:38 UTC
Patch posted:
https://www.redhat.com/archives/libguestfs/2016-June/msg00058.html

Comment 3 Xianghua Chen 2016-06-28 06:24:05 UTC
Verified with the packages:
libguestfs-1.32.5-6.el7.x86_64

Verify steps:
1.  Prepare an rhel7 image:  RHEL-Server-7.2-64-hvm.raw
2. Use  --truncate-recursive to truncate a no-existing path:
# virt-customize -a  RHEL-Server-7.2-64-hvm.raw --truncate-recursive /home/noexist
[   0.0] Examining the guest ...
[   3.4] Setting a random seed
[   3.4] Recursively truncating: /home/noexist
virt-customize: error: libguestfs error: find0: /home/noexist: No such file 
or directory

If reporting bugs, run virt-customize with debugging enabled and include 
the complete output:

  virt-customize -v -x [...]


It gives obvious error as above.

So verified.

Comment 5 errata-xmlrpc 2016-11-03 18:01:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2576.html