Bug 1345843

Summary:	showing diff of two binary files is nonsense
Product:	[Community] Spacewalk	Reporter:	Pavel Studeník <pstudeni>
Component:	Clients	Assignee:	Eric Herget <eherget>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jan Hutař <jhutar>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	2.5	CC:	galtukho, ggainey, jdobes, jhutar, satqe-list, tlestach
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	spacewalk-backend-2.6.15-1 rhncfg-5.10.96-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1345841
Clones:	1395881 (view as bug list)		Environment:
Last Closed:	2017-09-27 19:11:19 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1345841
Bug Blocks:	1395881, 1484117

Description Pavel Studeník 2016-06-13 10:02:08 UTC

+++ This bug was initially created as a clone of Bug #1345841 +++

Description of problem:
I created configuration channels and upload some plain text and some binary files (zips) to them. When I have to compare all local files then I received strings of binary file. I think that it is not good solution. We can look at behaviour bash application 'diff' and we can see:

>> diff /root/binary.dat /dev/null 
Binary files /root/binary.dat and /dev/null differ

Version-Release number of selected component (if applicable):
rhncfg-5.10.74-10.el6sat.noarch

How reproducible:
always

Steps to Reproduce:
1. create configure channel with binary file
2. subscribe this channel
3. rhncfg-client diff /file.binary
   rhncfg-namager diff /file.binary -c channel

Actual results:
diff two binary files:
+k]r >W_?S-LB9l쳼Ef[lQUlˋe ?LV׊+2az7PՓnYq2Gbq&<5˂r`laT䣛S/5U^>'
                                                               4[sUO.&t[gn/Sێ;n4M=8Wg5|Jΐ(c=IHI-~=0|l(D)$>jm5}'-VY+?M
$zİ23Zo8[}3\0d>wN(nGT1oNj\4!t)u
-kl#GFe9-^Ǟ@S ?0bkVp2fBSUZ}Qo-&ƂC`JI7-jIFU*3o}R-Xy-sy2_P-XukƁx_bM O5XZV&(plR4+"y=-t3    `fq


Expected results:
something as:
Binary files /root/binary.dat and /dev/null differ

Comment 1 Eric Herget 2016-07-29 13:14:05 UTC

spacewalk.github:
7a9d0118cd9c0b000c510db7565f9d696867998a

Comment 2 Jan Hutař 2016-11-10 21:55:31 UTC

I have tested on both SWnightly@OracleXE10@RHEL6 and SWnightly@PostgreSQL@RHEL7 (rhncfg-5.10.98-1.el6.noarch).

Output is now like this:

# rhncfg-client diff /tmp/binary
Using server name <fqdn>
Binary file content differs.
# rhncfg-manager diff /tmp/binary -c bz1358484 
Using server name <fqdn>
--- /tmp/binary	2016-11-10 22:46:59.687109	attributes: -rw-r--r-- root root 	config channel: bz1358484	revision: 1
+++ /tmp/binary	2016-11-10 22:50:15	attributes: -rw-r--r-- root root unconfined_u:object_r:rpm_tmp_t:s0	config channel: local file	revision: None
Binary file content differs

=> VERIFIED

Comment 3 Eric Herget 2017-09-27 19:11:19 UTC

This looks like it was fixed in previous release, but I'm closing it in this one.

Spacewalk 2.7 has been released.

https://github.com/spacewalkproject/spacewalk/wiki/ReleaseNotes27