Bug 1346018

Spec URL: https://raphgro.fedorapeople.org/review/java/jmake/jmake.spec
SRPM URL: https://raphgro.fedorapeople.org/review/java/jmake/jmake-1.3.8.8-1.20150716git7761ee3.fc24.src.rpm

- fixed version
- try to fix rpmlint:

$ rpmlint SPECS/jmake.spec SRPMS/jmake-1.3.8.8-1.20150716git7761ee3.fc24.src.rpm RPMS/noarch/jmake-1.3.8.8-1.20150716git7761ee3.fc24.noarch.rpm RPMS/noarch/jmake-javadoc-1.3.8.8-1.20150716git7761ee3.fc24.noarch.rpm 
jmake.noarch: W: unexpanded-macro Provides mvn(org.pantsbuild:jmake:pom:) = %VERSION% %VERSION
jmake.noarch: W: no-manual-page-for-binary jmake
3 packages and 1 specfiles checked; 0 errors, 2 warnings.

- No idea how to set a value for %VERSION%.
- Help output is not compatible with help2man.

hi
you must set:
javac.source, javac.target, default.javac.source and default.javac.target to 1.6
and you must sure which javadoc.encoding and source.encoding is set to UTF-8
see nbproject/build-impl.xml
<property name="default.javac.source" value="1.4"/>
<property name="default.javac.target" value="1.4"/>

e.g. 
ant -DVERSION=%{srcversion} \
 -Ddefault.javac.source=1.6 \
 -Ddefault.javac.target=1.6 \
 ...

(In reply to Raphael Groner from comment #1)
> jmake.noarch: W: unexpanded-macro Provides mvn(org.pantsbuild:jmake:pom:) =
> %VERSION% %VERSION
> jmake.noarch: W: no-manual-page-for-binary jmake
> 3 packages and 1 specfiles checked; 0 errors, 2 warnings.
> 
> - No idea how to set a value for %VERSION%.
sed -i "s/%VERSION%/%version/" jmake.pom ?
and
sed -i "s/%TAG%/%commit0/" jmake.pom

That's a cool idea to use ant properties instead of sed patching. I'll try soon.

Fixed. Thanks!

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14487921

> rpmlint SPECS/jmake.spec SRPMS/jmake-1.3.8.8-1.20150716git7761ee3.fc24.src.rpm RPMS/noarch/jmake-1.3.8.8-1.20150716git7761ee3.fc24.noarch.rpm RPMS/noarch/jmake-javadoc-1.3.8.8-1.20150716git7761ee3.fc24.noarch.rpm                                                          
jmake.noarch: W: no-manual-page-for-binary jmake
3 packages and 1 specfiles checked; 0 errors, 1 warnings.

Ops ...
please, change:
%mvn_artifact %{name}.pom

%install
%mvn_artifact org.pantsbuild.%{name}:%{name}:%{version} dist/%{name}.jar

in
....
%endif

%install
%mvn_artifact %{name}.pom dist/%{name}.jar

... and also ...
ant \
%if 0%{?fedora}
 -Ddefault.javac.source=1.8 -Ddefault.javac.target=1.8
%else
 -Ddefault.javac.source=1.7 -Ddefault.javac.target=1.7
%endif

with

ant -Ddefault.javac.source=1.7 -Ddefault.javac.target=1.7

should be enough ...

ok, fixed.

... sorry forgot ...
please, remove
Requires:       java-headless 
... for us is useless

ok, fixed.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 41 files have unknown license. Detailed
     output of licensecheck in /home/gil/1346018-jmake/licensecheck.txt
 Only these files are without license headers. Please, report to upsteram
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/classfilereader/Parent.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/ClassFileReaderTest.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/CompileResult.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/PCDManagerTest.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/PCDSerializationTest.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/TestPCDUtils.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/UtilsTest.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/packageinfo/package-info.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase1/A.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase1/B.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase1/C.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase2/orig-files/with-extra
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase2/orig-files/without-extra
 
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
     Note: Multiple Release: tags found
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It
     is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in jmake-
     javadoc
[x]: Package functions as described.
[x]: Latest version is packaged.
[?]: Package does not include license text files separate from upstream.
 Why use this pre-release? Please, add a comment in the spec file
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: jmake-1.3.8.8-1.20150716git7761ee3.fc25.noarch.rpm
          jmake-javadoc-1.3.8.8-1.20150716git7761ee3.fc25.noarch.rpm
          jmake-1.3.8.8-1.20150716git7761ee3.fc25.src.rpm
jmake.noarch: W: no-manual-page-for-binary jmake
3 packages and 0 specfiles checked; 0 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
jmake.noarch: W: no-manual-page-for-binary jmake
2 packages and 0 specfiles checked; 0 errors, 1 warnings.



Requires
--------
jmake-javadoc (rpmlib, GLIBC filtered):
    javapackages-tools

jmake (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools



Provides
--------
jmake-javadoc:
    jmake-javadoc

jmake:
    jmake
    mvn(org.pantsbuild:jmake)
    mvn(org.pantsbuild:jmake:pom:)



Source checksums
----------------
https://github.com/pantsbuild/jmake/archive/7761ee3e1537ccc61820c0d30061eb09edaf1c93.tar.gz#/jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93.tar.gz :
  CHECKSUM(SHA256) this package     : 5f1c1364c14bf2b6d27e3216bbfcdb13570fabf3711656b73f5e9ac93f02510f
  CHECKSUM(SHA256) upstream package : 5f1c1364c14bf2b6d27e3216bbfcdb13570fabf3711656b73f5e9ac93f02510f


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1346018 --plugins Java -m fedora-rawhide-i386
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, Java
Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Issues:

[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 41 files have unknown license. Detailed
     output of licensecheck in /home/gil/1346018-jmake/licensecheck.txt
 Only these files are without license headers. Please, report to upsteram
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/classfilereader/Parent.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/ClassFileReaderTest.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/CompileResult.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/PCDManagerTest.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/PCDSerializationTest.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/TestPCDUtils.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/org/pantsbuild/jmake/UtilsTest.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/packageinfo/package-info.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase1/A.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase1/B.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase1/C.java
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase2/orig-files/with-extra
 jmake-7761ee3e1537ccc61820c0d30061eb09edaf1c93/test/testcase2/orig-files/without-extra

Thanks. Reported license issue to upstream.
https://github.com/pantsbuild/jmake/issues/24

Anyways, that should not block the review. Package license is for built binary, we see questionable test files only. The License: field refers to the licenses of the contents of the binary rpm.

(In reply to Raphael Groner from comment #12)
> Thanks. Reported license issue to upstream.
> https://github.com/pantsbuild/jmake/issues/24
> 
> Anyways, that should not block the review. Package license is for built
> binary, we see questionable test files only. The License: field refers to
> the licenses of the contents of the binary rpm.

Approved

Thanks for the review!

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/jmake

jmake-1.3.8.8-2.20150716git7761ee3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-078696f754

jmake-1.3.8.8-2.20150716git7761ee3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-bbb939d86b

jmake-1.3.8.8-2.20150716git7761ee3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-078696f754

jmake-1.3.8.8-2.20150716git7761ee3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-bbb939d86b

jmake-1.3.8.8-2.20150716git7761ee3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

jmake-1.3.8.8-2.20150716git7761ee3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.