Bug 1346034

Summary: Azure provider unable to refresh when elements have non-ascii characters
Product: Red Hat CloudForms Management Engine Reporter: John Prause <jprause>
Component: ProvidersAssignee: Daniel Berger <dberger>
Status: CLOSED ERRATA QA Contact: Jeff Teehan <jteehan>
Severity: high Docs Contact:
Priority: unspecified    
Version: 5.5.0CC: bdunne, carnott, cpelland, dberger, fdewaley, jfrey, jhardy, jocarter, jprause, mfeifer, obarenbo
Target Milestone: GAKeywords: ZStream
Target Release: 5.5.5   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: 5.5.5.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1345888 Environment:
Last Closed: 2016-07-26 15:35:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1345888    
Bug Blocks:    
Attachments:
Description Flags
bz_1346034_2.tgz
none
bz_1346034_3.tgz
none
bz_1346034_4.tgz
none
bz_1346034_5.tgz none

Comment 9 Brandon Dunne 2016-06-15 22:07:24 UTC
Created attachment 1168523 [details]
bz_1346034_2.tgz

Fix URI encoding issues in azure-armrest gem

Comment 12 Brandon Dunne 2016-06-16 14:15:26 UTC
Created attachment 1168754 [details]
bz_1346034_3.tgz

URI.escape more urls that may have invalid characters

Comment 15 Brandon Dunne 2016-06-16 17:55:05 UTC
Created attachment 1168814 [details]
bz_1346034_4.tgz

Updated again to rescue failures when trying to fetch URIs with invalid characters.

Comment 17 Brandon Dunne 2016-06-20 16:28:14 UTC
Created attachment 1169945 [details]
bz_1346034_5.tgz

Includes the recently released azure-signature v0.2.2

Comment 18 Daniel Berger 2016-06-20 17:22:17 UTC
https://github.com/ManageIQ/manageiq/pull/9294

Comment 21 Jeff Teehan 2016-07-11 22:35:31 UTC
I was able to force this by uploading a disk, but the disk name in question cannot be created in azure under normal circumstances.  I'm not convinced our workaround is such a great idea.  That said, this bug as written is fixed.

Here is the Azure error that the user should have received which includes a list of invalid characters:

Failed to attach new disk 'RetireFrom11-20160711-{152929}' to the virtual machine 'RetireFrom11'. Error: InvalidParameter: The entity name 'dataDisk.name' is invalid according to its validation rule: ^[^_\W][\w-._]{0,79}(?<![-.])$.

Comment 22 Daniel Berger 2016-07-12 13:07:01 UTC
Jeff, I would argue that it's a bug in Azure then. I don't think there's any issue with our fix, since we're just reporting what they've got.

Comment 24 errata-xmlrpc 2016-07-26 15:35:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-1488.html