Bug 1346458
| Summary: | Review Request: perl-Test-Needs - Skip tests when modules not available | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Emmanuel Seyman <emmanuel> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-06-15 18:46:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1344670 | ||
|
Description
Emmanuel Seyman
2016-06-14 21:30:13 UTC
URL Source addresses are usable. Ok.
Source archive is original (SHA-256: 97e9827e1b14a61151509a229b153010811831437fa24db49ea76f73bed05e05). Ok.
Summary verified from lib/Test/Needs.pm. Ok.
Description verified from lib/Test/Needs.pm. Ok.
License verified from lib/Test/Needs.pm and README. Ok.
TODO: Constrain `perl(Test::More)' build-dependency with `>= 0.45' (META.json:37).
maint/Makefile.PL.include not used. Ok.
All test pass. Ok.
$ rpmlint perl-Test-Needs.spec ../SRPMS/perl-Test-Needs-0.002002-1.fc25.src.rpm ../RPMS/noarch/perl-Test-Needs-0.002002-1.fc25.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Test-Needs-0.002002-1.fc25.noarch.rpm
drwxr-xr-x 2 root root 0 Jun 15 11:00 /usr/share/doc/perl-Test-Needs
-rw-r--r-- 1 root root 761 Jun 3 16:42 /usr/share/doc/perl-Test-Needs/Changes
-rw-r--r-- 1 root root 2653 Jun 3 16:42 /usr/share/doc/perl-Test-Needs/README
-rw-r--r-- 1 root root 2302 Jun 15 11:00 /usr/share/man/man3/Test::Needs.3pm.gz
drwxr-xr-x 2 root root 0 Jun 15 11:00 /usr/share/perl5/vendor_perl/Test
-rw-r--r-- 1 root root 7856 Jun 3 16:41 /usr/share/perl5/vendor_perl/Test/Needs.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Test-Needs-0.002002-1.fc25.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.24.0)
1 perl(strict)
1 perl(Test2::Event)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Test-Needs-0.002002-1.fc25.noarch.rpm | sort -f | uniq -c
1 perl(Test::Needs) = 0.002002
1 perl-Test-Needs = 0.002002-1.fc25
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Test-Needs-0.002002-1.fc25.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F25 (http://koji.fedoraproject.org/koji/taskinfo?taskID=14498755). Ok.
Package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the `TODO' item before building this package.
Resolution: Package APPROVED.
(In reply to Petr Pisar from comment #1) > > TODO: Constrain `perl(Test::More)' build-dependency with `>= 0.45' > (META.json:37). I've done this locally so it will be in the initial package. > Resolution: Package APPROVED. Thank you for the review, Petr. I've requested a repo in pkgdb. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test-Needs Built for rawhide and released as an update for F24. |