Bug 1346729

Summary: /usr/share/ovirt-engine/dbscripts/engine-psql.sh has hardcoded db name ('engine' )
Product: Red Hat Enterprise Virtualization Manager Reporter: Jiri Belka <jbelka>
Component: redhat-support-plugin-rhevAssignee: Derrick Ornelas <dornelas>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: low Docs Contact:
Priority: low    
Version: 3.6.0CC: awels, dornelas, gklein, jmoran, lsurette, mkalinin, mperina, oourfali, pstehlik, rbalakri, srevivo, ykaul
Target Milestone: ovirt-4.0.2   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-28 10:30:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: UX RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jiri Belka 2016-06-15 09:06:15 UTC
Description of problem:

Not sure if having hardcoded db name is valid approach here:

# grep '^psql' /usr/share/ovirt-engine/dbscripts/engine-psql.sh                                                                                                                                  
psql -U "${USERNAME}" -h "${HOST}" -p "${port}" engine "$@" | tee -a "${LOGFILE}" 2>&1


Version-Release number of selected component (if applicable):
redhat-support-plugin-rhev-3.6.0-15.el6.noarch
redhat-support-plugin-rhev-4.0.0-4.el7ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. check if db name is a variable or hardcoded in shell script
2.
3.

Actual results:
db name is hardcoded

Expected results:
should be variable, let's imagine remote db

Additional info:
not tested against remote db, just checking a part of the code

Comment 12 Gil Klein 2016-07-28 10:30:04 UTC
This bug was fixed and is slated to be in the upcoming version. As we
are focusing our testing at this phase on severe bugs, this bug was
closed without going through its verification step. If you think this
bug should be verified by QE, please set its severity to high and move
it back to ON_QA