Bug 1347819

Summary:	glibc: Avoid build failure in TZ tests (related to timezone/testdata/XT1 etc.)
Product:	Red Hat Enterprise Linux 7	Reporter:	Florian Weimer <fweimer>
Component:	glibc	Assignee:	glibc team <glibc-bugzilla>
Status:	CLOSED DUPLICATE	QA Contact:	qe-baseos-tools-bugs
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.3	CC:	ashankar, codonell, fweimer, mnewsome, pfrankli
Target Milestone:	rc	Keywords:	Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:	1333940	Environment:
Last Closed:	2017-10-05 22:05:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1333940
Bug Blocks:	1473718

Description Florian Weimer 2016-06-17 17:57:29 UTC

+++ This bug was initially created as a clone of Bug #1333940 +++

glibc-2.22-12.fc23.i686 failed with:

cp testdata/XT1 /builddir/build/BUILD/glibc-2.22/build-i686-redhat-linux/timezone/testdata/XT1
cp testdata/XT2 /builddir/build/BUILD/glibc-2.22/build-i686-redhat-linux/timezone/testdata/XT2
cp testdata/XT3 /builddir/build/BUILD/glibc-2.22/build-i686-redhat-linux/timezone/testdata/XT3
cp testdata/XT4 /builddir/build/BUILD/glibc-2.22/build-i686-redhat-linux/timezone/testdata/XT4
cp: cp: cannot create regular file '/builddir/build/BUILD/glibc-2.22/build-i686-redhat-linux/timezone/testdata/XT1'cannot create regular file '/builddir/build/BUILD/glibc-2.22/build-i686-redhat-linux/timezone/testdata/XT3': No such file or directory: No such file or directory
Makefile:126: recipe for target '/builddir/build/BUILD/glibc-2.22/build-i686-redhat-linux/timezone/testdata/XT1' failed
make[2]: *** [/builddir/build/BUILD/glibc-2.22/build-i686-redhat-linux/timezone/testdata/XT1] Error 1
make[2]: *** Waiting for unfinished jobs....
Makefile:126: recipe for target '/builddir/build/BUILD/glibc-2.22/build-i686-redhat-linux/timezone/testdata/XT3' failed
make[2]: *** [/builddir/build/BUILD/glibc-2.22/build-i686-redhat-linux/timezone/testdata/XT3] Error 1

This is likely due to lack of the following upstream fix (which went into 2.23):

commit 3cc652e951c71785032019fec82e3b8543d85305
Author: Mike Frysinger <vapier>
Date:   Fri Sep 18 13:49:08 2015 -0400

    timezone: fix parallel check failures
    
    The XT testdata install rules expect the testdata dir to already exist in
    the build tree, but it doesn't actually create it.  Instead, it relies on
    the build-testdata define happening to be executed before it (which runs
    zic which creates the dir).  When we run in parallel though, it's easy to
    hit a failure:
    $ cd timezone
    $ rm -rf $objdir/timezone/testdata
    $ make check -j
    ...
    cp testdata/XT1 .../timezone/testdata/XT1
    cp: cannot create regular file '.../timezone/testdata/XT1': No such file or directory
    Makefile:116: recipe for target '.../timezone/testdata/XT1' failed
    make: *** [.../timezone/testdata/XT1] Error 1
    make: *** Waiting for unfinished jobs....

--- Additional comment from Fedora Update System on 2016-05-07 19:19:29 CEST ---

glibc-2.22-15.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-68abc0be35

--- Additional comment from Fedora Update System on 2016-05-08 18:25:26 CEST ---

glibc-2.22-15.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-68abc0be35

--- Additional comment from Fedora Update System on 2016-05-10 19:57:31 CEST ---

glibc-2.22-15.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 4 Carlos O'Donell 2017-10-05 22:05:06 UTC

I'm merging this into bug 1378329, and Patsy will fix both issues as part of fixing the timezone testdata testing. It's really *one* bug, fix the test case. That one bug requires two implementation level changes: patch the data correctly, and fix the dependencies.

*** This bug has been marked as a duplicate of bug 1378329 ***