Bug 1347853
| Summary: | Review Request: rubygem-prawn-icon - Provides icon fonts for PrawnPDF | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Alessandro Locati <fale> |
| Component: | Package Review | Assignee: | Germano Massullo <germano.massullo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | germano.massullo, package-review |
| Target Milestone: | --- | Flags: | germano.massullo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-06-29 12:55:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1347858 | ||
|
Description
Fabio Alessandro Locati
2016-06-17 20:59:20 UTC
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gems, /usr/share/gems/doc [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem- prawn-icon-doc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [!]: When checking ruby code, install the ruby plugin. Installation errors ------------------- INFO: mock.py version 1.2.17 starting (python version = 3.5.1)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata Mock Version: 1.2.17 INFO: Mock Version: 1.2.17 Finish: chroot init INFO: installing package(s): /tmp/rubygem-prawn-icon/results/rubygem-prawn-icon-doc-1.1.0-1.fc25.noarch.rpm /tmp/rubygem-prawn-icon/results/rubygem-prawn-icon-1.1.0-1.fc25.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 25 --disableplugin=local --setopt=deltarpm=false install /tmp/rubygem-prawn-icon/results/rubygem-prawn-icon-doc-1.1.0-1.fc25.noarch.rpm /tmp/rubygem-prawn-icon/results/rubygem-prawn-icon-1.1.0-1.fc25.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: rubygem-prawn-icon-1.1.0-1.fc25.noarch.rpm rubygem-prawn-icon-doc-1.1.0-1.fc25.noarch.rpm rubygem-prawn-icon-1.1.0-1.fc25.src.rpm rubygem-prawn-icon.noarch: E: script-without-shebang /usr/share/gems/gems/prawn-icon-1.1.0/data/fonts/pf/LICENSE rubygem-prawn-icon.noarch: E: script-without-shebang /usr/share/gems/gems/prawn-icon-1.1.0/data/fonts/octicon/LICENSE rubygem-prawn-icon.noarch: E: incorrect-fsf-address /usr/share/gems/gems/prawn-icon-1.1.0/GPLv2 3 packages and 0 specfiles checked; 3 errors, 0 warnings. Requires -------- rubygem-prawn-icon-doc (rpmlib, GLIBC filtered): rubygem-prawn-icon rubygem-prawn-icon (rpmlib, GLIBC filtered): ruby(rubygems) rubygem(prawn) Provides -------- rubygem-prawn-icon-doc: rubygem-prawn-icon-doc rubygem-prawn-icon: rubygem(prawn-icon) rubygem-prawn-icon Source checksums ---------------- https://rubygems.org/gems/prawn-icon-1.1.0.gem : CHECKSUM(SHA256) this package : 5e085dd6b1b55ddb352c053f635fbe8e28d4be5d57ff2ea555278373bb8a5a96 CHECKSUM(SHA256) upstream package : 5e085dd6b1b55ddb352c053f635fbe8e28d4be5d57ff2ea555278373bb8a5a96 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -r -m fedora-rawhide-x86_64 -n /home/fale/rpmbuild/SRPMS/rubygem-prawn-icon-1.1.0-1.fc24.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Congratulations, the package is approved! Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-prawn-icon rubygem-asciidoctor-pdf-1.5.0-0.1.alpha.11.fc23 rubygem-prawn-icon-1.1.0-1.fc23 rubygem-prawn-svg-0.25.1-1.fc23 rubygem-css_parser-1.4.2-1.fc23 rubygem-prawn-table-0.2.2-1.fc23 rubygem-prawn-manual_builder-0.2.0-1.fc23 rubygem-prawn-templates-0.0.4-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f072509871 rubygem-asciidoctor-pdf-1.5.0-0.1.alpha.11.fc24 rubygem-prawn-icon-1.1.0-1.fc24 rubygem-prawn-svg-0.25.1-1.fc24 rubygem-css_parser-1.4.2-1.fc24 rubygem-prawn-table-0.2.2-1.fc24 rubygem-prawn-manual_builder-0.2.0-1.fc24 rubygem-prawn-templates-0.0.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3002f036fc rubygem-asciidoctor-pdf-1.5.0-0.1.alpha.11.fc24, rubygem-css_parser-1.4.2-1.fc24, rubygem-prawn-icon-1.1.0-1.fc24, rubygem-prawn-manual_builder-0.2.0-1.fc24, rubygem-prawn-svg-0.25.1-1.fc24, rubygem-prawn-table-0.2.2-1.fc24, rubygem-prawn-templates-0.0.4-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3002f036fc rubygem-asciidoctor-pdf-1.5.0-0.1.alpha.11.fc23, rubygem-css_parser-1.4.2-1.fc23, rubygem-prawn-icon-1.1.0-1.fc23, rubygem-prawn-manual_builder-0.2.0-1.fc23, rubygem-prawn-svg-0.25.1-1.fc23, rubygem-prawn-table-0.2.2-1.fc23, rubygem-prawn-templates-0.0.4-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f072509871 rubygem-asciidoctor-pdf-1.5.0-0.1.alpha.11.fc24, rubygem-css_parser-1.4.2-1.fc24, rubygem-prawn-icon-1.1.0-1.fc24, rubygem-prawn-manual_builder-0.2.0-1.fc24, rubygem-prawn-svg-0.25.1-1.fc24, rubygem-prawn-table-0.2.2-1.fc24, rubygem-prawn-templates-0.0.4-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. rubygem-asciidoctor-pdf-1.5.0-0.1.alpha.11.fc23, rubygem-css_parser-1.4.2-1.fc23, rubygem-prawn-icon-1.1.0-1.fc23, rubygem-prawn-manual_builder-0.2.0-1.fc23, rubygem-prawn-svg-0.25.1-1.fc23, rubygem-prawn-table-0.2.2-1.fc23, rubygem-prawn-templates-0.0.4-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |