Bug 1347869

Summary:	/usr/include/wireshark/config.h includes ws_diag_control.h which is not available
Product:	[Fedora] Fedora	Reporter:	Sandro Mani <manisandro>
Component:	wireshark	Assignee:	Peter Hatina <phatina>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	24	CC:	berrange, crobinso, hedayatv, huzaifas, lemenkov, mprivozn, phatina, rvokal
Target Milestone:	---	Keywords:	BuildBlocker, Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	wireshark-2.1.0-2.fc25 wireshark-2.1.0-3.fc24	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-07-20 17:49:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sandro Mani 2016-06-17 21:52:15 UTC

Description of problem:
/usr/include/wireshark/config.h includes ws_diag_control.h, but this header is not installed with wireshark-devel (and is indeed listed in noinst_HEADERS).

Versions of wireshark before 2.1.0 did not have the #include <ws_diag_control.h> statement in config.h

I suppose the easy fix is to install ws_diag_control.h even if it is in noinst_HEADERS.


Version-Release number of selected component (if applicable):
wireshark-2.1.0-1.fc25.x86_64


Additional info:
This is causing openambit to FTBFS.

Comment 1 Sandro Mani 2016-06-24 20:59:02 UTC

Hi,
wireshark-2.1.0-2 installs ws_symbol_export.h and not ws_diag_control.h, which is the missing header. Could you install ws_diag_control.h also/instead?

Thanks

Comment 2 Sandro Mani 2016-07-02 11:19:35 UTC

Ping?

Comment 3 Michal Privoznik 2016-07-04 07:17:00 UTC

Agreed, the commit that tried to fixed this issue is terribly flawed:

http://pkgs.fedoraproject.org/cgit/rpms/wireshark.git/commit/?id=d6256793ec1d98ee81175df737696b3d47385bad

Even though it claims ws_diag_control.h is installed after it (in the changelog), in fact is installing ws_symbol_export.h (which seems to be needed too).

As a result of this bug, any software providing their own wireshark dissector will fail to build, therefore setting BuildBlocker keyword.

Comment 4 Hedayat Vatankhah 2016-07-10 13:15:29 UTC

The problem exists in F24 (wireshark-devel-2.1.0-2.fc24.x86_64) too. Also, #1351984 is duplicate of this bug.

Comment 5 Peter Hatina 2016-07-13 10:34:03 UTC

I'll try to fix this ASAP.

Comment 6 Cole Robinson 2016-07-13 14:03:06 UTC

*** Bug 1351984 has been marked as a duplicate of this bug. ***

Comment 7 Fedora Update System 2016-07-14 06:25:24 UTC

wireshark-2.1.0-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-72f53e325a

Comment 8 Fedora Update System 2016-07-14 22:28:09 UTC

wireshark-2.1.0-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-72f53e325a

Comment 9 Fedora Update System 2016-07-20 17:49:09 UTC

wireshark-2.1.0-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.