Bug 1347980

Summary:	Review Request: aries-proxy-api - Apache Aries Proxy API
Product:	[Fedora] Fedora	Reporter:	gil cattaneo <puntogil>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-08-27 10:39:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1347972
Bug Blocks:	1166655, 1181081, 1348146, 1365144

Description gil cattaneo 2016-06-19 13:57:02 UTC

Spec URL: https://gil.fedorapeople.org/aries-proxy-api.spec
SRPM URL: https://gil.fedorapeople.org/aries-proxy-api-1.0.1-1.fc23.src.rpm
Description: This bundle contains the Apache Aries Proxy service API.
Fedora Account System Username: gil

Comment 1 gil cattaneo 2016-08-10 16:48:11 UTC

Spec URL: https://gil.fedorapeople.org/aries-proxy-api.spec
SRPM URL: https://gil.fedorapeople.org/aries-proxy-api-1.0.1-1.fc24.src.rpm

Comment 2 Zbigniew Jędrzejewski-Szmek 2016-08-10 23:35:02 UTC

+ license is acceptable (ASL 2.0)
+ license is specified correctly
+ package name is OK
+ package builds and installs correctly
+ no scriptlets present or necessary
+ standard maven build macros are used
+ provides/requires/buildrequires look OK
+ rpmlint is happy (on warning about missing documentation, but there's -javadoc)
+ fedora-review is happy (I won't paste the full output here, there's little of interest)

Package is APPROVED.

It *would* be nice to move %description to Summary, and provide a bit longer description what the package actually does in %description.

Comment 3 gil cattaneo 2016-08-11 00:19:41 UTC

(In reply to Zbigniew Jędrzejewski-Szmek from comment #2)

> Package is APPROVED.

Thanks very much for the review!

> It *would* be nice to move %description to Summary, and provide a bit longer
> description what the package actually does in %description.

any suggestion regarding the %description is well accepted

create new SCM requests:
https://admin.fedoraproject.org/pkgdb/package/requests/7145
https://admin.fedoraproject.org/pkgdb/package/requests/7146

Comment 4 Gwyn Ciesla 2016-08-11 13:36:36 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/aries-proxy-api

Comment 5 Fedora Update System 2016-08-11 14:07:45 UTC

aries-proxy-api-1.0.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-cd4b4525aa

Comment 6 Fedora Update System 2016-08-11 16:55:16 UTC

aries-proxy-api-1.0.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cd4b4525aa

Comment 7 Fedora Update System 2016-08-27 10:39:48 UTC

aries-proxy-api-1.0.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.