Bug 1348198
Summary: | [RFE] cannot easily change active_slave | |||
---|---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Vladimir Benes <vbenes> | |
Component: | NetworkManager | Assignee: | Beniamino Galvani <bgalvani> | |
Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> | |
Severity: | medium | Docs Contact: | ||
Priority: | medium | |||
Version: | 7.3 | CC: | aloughla, atragler, bgalvani, lrintel, rkhan, sukulkar, thaller | |
Target Milestone: | rc | Keywords: | FutureFeature | |
Target Release: | --- | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | NetworkManager-1.8.0-0.4.rc1.el7 | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1428420 (view as bug list) | Environment: | ||
Last Closed: | 2017-08-01 09:17:07 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1299103, 1393481, 1428420 |
Description
Vladimir Benes
2016-06-20 12:23:22 UTC
I wonder if the "active_slave" setting in a connection make sense. To me a ~connection~ is some a static description of configuration, while the active-slave is a setting that matters to a device (at runtime, so to say). We already have ways to set properties on the device: nmcli device modify $IFACE <autoconnect|managed> maybe nmcli device modify $IFACE active-slave $SLAVE would be a good fit. (In reply to Thomas Haller from comment #1) > I wonder if the "active_slave" setting in a connection make sense. > > To me a ~connection~ is some a static description of configuration, while > the active-slave is a setting that matters to a device (at runtime, so to > say). > this is now valid option of BONDING_OPTS (not sure if it was ever supported by network script) so it's quite wrong if it's set when bond is created and then upped and there is something else in /sys/class/net/nm-bond/bonding/active_slave > > > We already have ways to set properties on the device: > > nmcli device modify $IFACE <autoconnect|managed> > > maybe > > nmcli device modify $IFACE active-slave $SLAVE > > would be a good fit. yeah, maybe it may be nice to have these modifications here just valid at runtime. would be nice to do this via: nmcli device modify bond0 bond.active_slave eth0 the problem is, that nmcli treads bond options in an clumsy way, where there is only one "bond.options" property. So, in the current scheme, above command would look like nmcli device modify bond0 +bond.options "active_slave=eth0" which is pretty bad. I would prefer to avoid adding other device properties for each bond options that can be changed at runtime. In my opinion the reapply facility is the way to go, even if the syntax might not be the easiest one for bonds. Pushed branch bg/bond-reapply-rh1348198 for review. Branch looks good to me as is (In reply to Beniamino Galvani from comment #4) > I would prefer to avoid adding other device properties for each bond options > that can be changed at runtime. In my opinion the reapply facility is the > way to go, even if the syntax might not be the easiest one for bonds. I fully agree with this. And I think our reapply mechanism and the settings-connection/applied-connection split is pretty awesome with lots of potential uses (like this feature). Thanks. Merged to master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=6b7419c780defa71726169ef5b2cbb89dff93f7d Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2017:2299 |