Bug 1348263

Summary:	Ballooning will not work when IO QoS is not defined
Product:	[oVirt] vdsm	Reporter:	Martin Sivák <msivak>
Component:	Core	Assignee:	Martin Sivák <msivak>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Shira Maximov <mshira>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	4.18.0	CC:	alukiano, bugs, dfediuck, eedri, mavital, mgoldboi, mshira, msivak, rgolan
Target Milestone:	ovirt-4.0.1	Keywords:	Automation, AutomationBlocker, Regression
Target Release:	---	Flags:	dfediuck: ovirt-3.6.z? rule-engine: ovirt-4.0.0+ rule-engine: blocker+ mgoldboi: planning_ack+ msivak: devel_ack+ mavital: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1346252
Clones:	1353559 (view as bug list)		Environment:
Last Closed:	2016-07-19 06:23:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	SLA	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1346252, 1356537, 1361554
Bug Blocks:	1353559

Description Martin Sivák 2016-06-20 15:30:14 UTC

VDSM needs to update mom configuration after new mom 0.5.5 is released.

+++ This bug was initially created as a clone of Bug #1346252 +++

Description of problem:
Mom will be doing nothing for VMs that have no IO QoS defined
Mom logs, reports missing fields for the vm:
Incomplete data: missing set(['io_tune_current', 'io_tune'])

Version-Release number of selected component (if applicable):
mom-0.5.4-1.el7ev.noarch


How reproducible:
100%

Steps to Reproduce:
1. Run VM with guest agent 
2. check mom logs, if you get: getVmBalloonInfo() is not ready ->> then the VM is not ready and no policy will be evaluated on it

3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Martin Sivák on 2016-06-14 13:48:14 CEST ---

We need to create GuestIoTuneOptional collector in MOM and then use it in VDSM's configuration file for MOM.

--- Additional comment from Roy Golan on 2016-06-15 08:00:27 CEST ---

Is the evaluation of policy is such inclusive? isn't it triggered with minimum requirements? If not it should be

--- Additional comment from Martin Sivák on 2016-06-15 10:21:28 CEST ---

(In reply to Roy Golan from comment #2)
> Is the evaluation of policy is such inclusive? isn't it triggered with
> minimum requirements? If not it should be

Uh? That is the whole point of this bug. The currently used GuestIoTune adds the io_tune variables to the list of required values.

--- Additional comment from Doron Fediuck on 2016-06-20 10:26:01 CEST ---



--- Additional comment from Red Hat Bugzilla Rules Engine on 2016-06-20 10:59:19 CEST ---

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 1 Red Hat Bugzilla Rules Engine 2016-06-29 08:47:03 UTC

Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 2 Eyal Edri 2016-07-12 06:54:33 UTC

Can this move to MODIFIED? i see the 4.0 patch for vdsm is merged

Comment 3 Shira Maximov 2016-07-15 11:44:20 UTC

verified on :
mom-0.5.5-1.el7ev.noarch

verification steps: 
1. Run VM with guest agent 
2. check mom logs ->> the logs are OK

Comment 4 Sandro Bonazzola 2016-07-19 06:23:15 UTC

Since the problem described in this bug report should be
resolved in oVirt 4.0.1 released on July 19th 2016, it has been closed with a
resolution of CURRENT RELEASE.

For information on the release, and how to update to this release, follow the link below.

If the solution does not work for you, open a new bug report.

http://www.ovirt.org/release/4.0.1/