Bug 1348327
| Summary: | vgcfgrestore segfaults if attempted with missing PV | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Corey Marthaler <cmarthal> | |
| Component: | lvm2 | Assignee: | LVM and device-mapper development team <lvm-team> | |
| lvm2 sub component: | Command-line tools | QA Contact: | cluster-qe <cluster-qe> | |
| Status: | CLOSED ERRATA | Docs Contact: | ||
| Severity: | high | |||
| Priority: | unspecified | CC: | agk, heinzm, jbrassow, mnavrati, msnitzer, prajnoha, prockai, rbednar, teigland, thornber, zkabelac | |
| Version: | 7.3 | Keywords: | Regression, TestBlocker | |
| Target Milestone: | rc | |||
| Target Release: | --- | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | lvm2-2.02.160-1.el7 | Doc Type: | No Doc Update | |
| Doc Text: |
Intra-release bug, no documentation needed.
|
Story Points: | --- | |
| Clone Of: | ||||
| : | 1583805 (view as bug list) | Environment: | ||
| Last Closed: | 2016-11-04 04:21:47 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1583805 | |||
|
Description
Corey Marthaler
2016-06-20 20:11:36 UTC
This has already fixed indirectly by this commit which makes vgcfgrestore not use lvmetad: https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=6ae22125c62ddea4340916a5e255d55844bfd087 $ vgcfgrestore -f /tmp/test.bak test Couldn't find device with uuid 7TXhnS-877L-KOp9-BTle-0E2C-23iD-Zh9n4E. Cannot restore Volume Group test with 1 PVs marked as missing. Restore failed. However, the code would still benefit from being defensive in the function identified in the backtrace, so I've pushed out this check for a missing device: https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=f96de674905cd9f109cd19e03ba5e92ac84104b8 Adding QA ACK for 7.3. Fix verified in the latest rpms. 3.10.0-480.el7.x86_64 lvm2-2.02.161-3.el7 BUILT: Thu Jul 28 09:31:24 CDT 2016 lvm2-libs-2.02.161-3.el7 BUILT: Thu Jul 28 09:31:24 CDT 2016 lvm2-cluster-2.02.161-3.el7 BUILT: Thu Jul 28 09:31:24 CDT 2016 device-mapper-1.02.131-3.el7 BUILT: Thu Jul 28 09:31:24 CDT 2016 device-mapper-libs-1.02.131-3.el7 BUILT: Thu Jul 28 09:31:24 CDT 2016 device-mapper-event-1.02.131-3.el7 BUILT: Thu Jul 28 09:31:24 CDT 2016 device-mapper-event-libs-1.02.131-3.el7 BUILT: Thu Jul 28 09:31:24 CDT 2016 device-mapper-persistent-data-0.6.3-1.el7 BUILT: Fri Jul 22 05:29:13 CDT 2016 cmirror-2.02.161-3.el7 BUILT: Thu Jul 28 09:31:24 CDT 2016 sanlock-3.4.0-1.el7 BUILT: Fri Jun 10 11:41:03 CDT 2016 sanlock-lib-3.4.0-1.el7 BUILT: Fri Jun 10 11:41:03 CDT 2016 lvm2-lockd-2.02.161-3.el7 BUILT: Thu Jul 28 09:31:24 CDT 2016 [root@host-079 ~]# lvs -a -o +devices WARNING: Device for PV dQka0Y-fc5Q-r0ZY-Otpm-z1yY-wXas-cmfSfR not found or rejected by a filter. LV VG Attr LSize Pool Origin Data% Meta% Move Log Cpy%Sync Convert Devices missing_pv_raid raid_sanity Rwi---r-p- 100.00m missing_pv_raid_rimage_0(0),missing_pv_raid_rimage_1(0) [missing_pv_raid_rimage_0] raid_sanity Iwi---r-p- 100.00m [unknown](1) [missing_pv_raid_rimage_1] raid_sanity Iwi---r--- 100.00m /dev/sdc1(1) [missing_pv_raid_rmeta_0] raid_sanity ewi---r-p- 4.00m [unknown](0) [missing_pv_raid_rmeta_1] raid_sanity ewi---r--- 4.00m /dev/sdc1(0) [root@host-079 ~]# vgcfgrestore -f /tmp/raid_sanity.bkup.21159 raid_sanity Couldn't find device with uuid dQka0Y-fc5Q-r0ZY-Otpm-z1yY-wXas-cmfSfR. Cannot restore Volume Group raid_sanity with 1 PVs marked as missing. Restore failed. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-1445.html |