Bug 1348442

Build fails on s390x with

...
libtool: compile:  gcc -DPACKAGE_NAME=\"libblockdev\" -DPACKAGE_TARNAME=\"libblockdev\" -DPACKAGE_VERSION=\"1.7\" "-DPACKAGE_STRING=\"libblockdev 1.7\"" -DPACKAGE_BUGREPORT=\"vpodzime\" -DPACKAGE_URL=\"\" -DPACKAGE=\"libblockdev\" -DVERSION=\"1.7\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_DLFCN_H=1 -DHAVE_STRING_H=1 -DHAVE_UNISTD_H=1 -DHAVE_SYS_FCNTL_H=1 -DHAVE_SYS_IOCTL_H=1 -DHAVE_LINUX_RANDOM_H=1 -DHAVE_GLOB_H=1 -DHAVE_SYSLOG_H=1 -DHAVE_MATH_H=1 -I. -I./../utils/ -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -Wall -Wextra -Werror -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -march=z9-109 -mtune=z10 -c s390.c  -fPIC -DPIC -o .libs/libbd_s390_la-s390.o
s390.c: In function 'bd_s390_dasd_format':
s390.c:75:42: error: passing argument 1 of 'bd_utils_exec_and_report_error' from incompatible pointer type [-Werror=incompatible-pointer-types]
     rc = bd_utils_exec_and_report_error (argv, error);
                                          ^~~~
In file included from ./../utils/utils.h:5:0,
                 from s390.c:25:
./../utils/exec.h:27:10: note: expected 'gchar ** {aka char **}' but argument is of type 'const gchar ** {aka const char **}'
 gboolean bd_utils_exec_and_report_error (gchar **argv, GError **error);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
s390.c: In function 'bd_s390_dasd_online':
s390.c:144:46: error: passing argument 1 of 'bd_utils_exec_and_report_error' from incompatible pointer type [-Werror=incompatible-pointer-types]
         rc = bd_utils_exec_and_report_error (argv, error);
                                              ^~~~
In file included from ./../utils/utils.h:5:0,
                 from s390.c:25:
./../utils/exec.h:27:10: note: expected 'gchar ** {aka char **}' but argument is of type 'const gchar ** {aka const char **}'
 gboolean bd_utils_exec_and_report_error (gchar **argv, GError **error);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
s390.c: In function 'bd_s390_zfcp_online':
s390.c:427:50: error: passing argument 1 of 'bd_utils_exec_and_report_error' from incompatible pointer type [-Werror=incompatible-pointer-types]
         boolrc = bd_utils_exec_and_report_error (zfcp_cio_free, NULL, error);
                                                  ^~~~~~~~~~~~~
In file included from ./../utils/utils.h:5:0,
                 from s390.c:25:
./../utils/exec.h:27:10: note: expected 'gchar ** {aka char **}' but argument is of type 'const gchar ** {aka const char **}'
 gboolean bd_utils_exec_and_report_error (gchar **argv, GError **error);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
s390.c:427:18: error: too many arguments to function 'bd_utils_exec_and_report_error'
         boolrc = bd_utils_exec_and_report_error (zfcp_cio_free, NULL, error);
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./../utils/utils.h:5:0,
                 from s390.c:25:
./../utils/exec.h:27:10: note: declared here
 gboolean bd_utils_exec_and_report_error (gchar **argv, GError **error);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
s390.c:471:50: error: passing argument 1 of 'bd_utils_exec_and_report_error' from incompatible pointer type [-Werror=incompatible-pointer-types]
         boolrc = bd_utils_exec_and_report_error (chccwdev, NULL, error);
                                                  ^~~~~~~~
In file included from ./../utils/utils.h:5:0,
                 from s390.c:25:
./../utils/exec.h:27:10: note: expected 'gchar ** {aka char **}' but argument is of type 'const gchar ** {aka const char **}'
 gboolean bd_utils_exec_and_report_error (gchar **argv, GError **error);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
s390.c:471:18: error: too many arguments to function 'bd_utils_exec_and_report_error'
         boolrc = bd_utils_exec_and_report_error (chccwdev, NULL, error);
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./../utils/utils.h:5:0,
                 from s390.c:25:
./../utils/exec.h:27:10: note: declared here
 gboolean bd_utils_exec_and_report_error (gchar **argv, GError **error);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libtool: link: gcc -shared  -fPIC -DPIC  .libs/libbd_crypto_la-crypto.o   -Wl,-rpath -Wl,/builddir/build/BUILD/libblockdev-1.7/src/utils/.libs -L./../utils/ -lssl3 -lsmime3 -lnss3 -lnssutil3 -lplds4 -lplc4 -lnspr4 -lpthread -ldl -lvolume_key ./../utils/.libs/libbd_utils.so -lglib-2.0 -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -O2 -g -fstack-protector-strong -grecord-gcc-switches -m64 -march=z9-109 -mtune=z10 -Wl,-z -Wl,relro   -Wl,-soname -Wl,libbd_crypto.so.0 -o .libs/libbd_crypto.so.0.0.1
s390.c: In function 'bd_s390_zfcp_offline':
s390.c:786:46: error: passing argument 1 of 'bd_utils_exec_and_report_error' from incompatible pointer type [-Werror=incompatible-pointer-types]
     failed = bd_utils_exec_and_report_error (chccwdev, NULL, error);
                                              ^~~~~~~~
In file included from ./../utils/utils.h:5:0,
                 from s390.c:25:
./../utils/exec.h:27:10: note: expected 'gchar ** {aka char **}' but argument is of type 'const gchar ** {aka const char **}'
 gboolean bd_utils_exec_and_report_error (gchar **argv, GError **error);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
s390.c:786:14: error: too many arguments to function 'bd_utils_exec_and_report_error'
     failed = bd_utils_exec_and_report_error (chccwdev, NULL, error);
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./../utils/utils.h:5:0,
                 from s390.c:25:
./../utils/exec.h:27:10: note: declared here
 gboolean bd_utils_exec_and_report_error (gchar **argv, GError **error);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Makefile:785: recipe for target 'libbd_s390_la-s390.lo' failed
...


Looks like the s390.c wasn't updated for recent changes in the shared code.

For full logs please see http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2263955
For access to s390x machine, please ping me.


Version-Release number of selected component (if applicable):
libblockdev-1.7-1.fc25