Bug 1348638
| Summary: | [RFE] - Need default validation for data type on TextBox fields when submitting Dialog (Web UI) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | John Prause <jprause> | ||||||
| Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Shveta <sshveta> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 5.6.0 | CC: | bilwei, hkataria, jhardy, mfeifer, mpovolny, obarenbo, simaishi, sshveta | ||||||
| Target Milestone: | GA | Keywords: | FutureFeature, ZStream | ||||||
| Target Release: | 5.6.1 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | ui:dialog | ||||||||
| Fixed In Version: | 5.6.1.2 | Doc Type: | Enhancement | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | 1319781 | Environment: | |||||||
| Last Closed: | 2016-08-18 17:48:12 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 1319781 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Comment 1
CFME Bot
2016-07-07 21:28:45 UTC
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/b0894e1e50c1d45256d032e890af6ead7dffe4db commit b0894e1e50c1d45256d032e890af6ead7dffe4db Author: Harpreet Kataria <hkataria> AuthorDate: Thu Jul 7 17:13:48 2016 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Jul 7 17:20:53 2016 -0400 Initialize data type for TextBox field to be string by default. Data type for TextBox field was being set to to nil by default, this was causing validation issues when dialog was submitted. https://bugzilla.redhat.com/show_bug.cgi?id=1319781 https://bugzilla.redhat.com/show_bug.cgi?id=1348638 app/controllers/miq_ae_customization_controller/dialogs.rb | 5 +++++ 1 file changed, 5 insertions(+) Created attachment 1186509 [details]
string
Created a dialog with "Integer" . Proper validation is shown while ordering the catalog Item ..
But when created a dialog with type "String" and provider Integer values while ordering catalog item , validation was not shown .
Created attachment 1186510 [details]
integer value
Shveta, For string type you can still type numbers, which are taken as a string, not integer. I think it is OK. John/Shveta, Removing need info flag as Bill has already provided information above. Let me know if you need any further info on this. ~Harpreet Verified in 5.6.1.0.20160726144018_810a94f Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2016-1634.html |