Bug 1348898

Summary: kdump's get_persistent_dev() has a name contention with dracut's function with same name
Product: [Fedora] Fedora Reporter: Pratyush Anand <panand>
Component: kexec-toolsAssignee: Pratyush Anand <panand>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: bhe, ruyang
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kexec-tools-2.0.12-7.fc24 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-02 15:25:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pratyush Anand 2016-06-22 09:27:19 UTC
Description of problem:

when /etc/kdump.conf has 'nsf 192.168.1.12:/nfsroot' and we restart kdumpctl, then sometime following error message is printed.

"Kernel dev name of 192.168.1.12:/nfsroot is not found."


Actually dracut-functions.sh defines a get_persistent_dev(). Earlier, we had another local get_persistent_dev() in mkdumprd, however that was moved to kdump-lib.sh, so that it can be reused in kdumpctl.
    
Since, dracut-module-setup.sh (which is dracut's 99kdumpbase/module-setup.sh) sources kdump-lib.sh. Therefore, once dracut will execute 99kdumpbase module, it's own get_persistent_dev() function is overwritten by kdump's version. If any other dracut module calls get_persistent_dev() thereafter then, kdump's version is executed, which was not expected.


Version-Release number of selected component (if applicable):

kexec-tools-2.0.12-5


Actual results:

`kdumpctl start' may throw warning message like "Kernel dev name of 192.168.1.12:/nfsroot is not found."

Expected results:

We should not see any such warning message.

Comment 1 Fedora Update System 2016-06-27 20:11:41 UTC
kexec-tools-2.0.12-7.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-0c53f33e9c

Comment 2 Fedora Update System 2016-06-28 15:22:21 UTC
kexec-tools-2.0.12-7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0c53f33e9c

Comment 3 Fedora Update System 2016-07-02 15:25:35 UTC
kexec-tools-2.0.12-7.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.