Bug 1349253

Summary:	"90kernel-modules" doesn't handle nfs host fstype properly
Product:	Red Hat Enterprise Linux 7	Reporter:	Xunlei Pang <xlpang>
Component:	dracut	Assignee:	Lukáš Nykrýn <lnykryn>
Status:	CLOSED ERRATA	QA Contact:	Release Test Team <release-test-team-automation>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	7.3	CC:	dracut-maint-list, dyoung, harald, jstodola, mkovarik, xlpang
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-04 08:05:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xunlei Pang 2016-06-23 04:54:51 UTC

Description of problem:
In 90kernel-modules/module-setup.sh installkernel(), dracut tries to instmods all "host_fs_types" with hostonly unset, this is useful for the fs target not mounted beforehand under hostonly mode (for example, using --mount to add some mount target). This works properly for most host fstypes(ext[234]/xfs, etc) except nfs.

Version-Release number of selected component (if applicable):
latest version

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
From nfs manpage, we can clearly see that:
"The fstype field contains "nfs". Use of the "nfs4" fstype in /etc/fstab is deprecated."

It means "nfs" specified can be actually mounted as "nfs[3-4]", so for these cases, the current 90kernel-modules implementation only installs ko modules for "nfs"(nfs.ko, etc), lacking nfsv[3-4].ko, so it cannot work properly.

Comment 1 Xunlei Pang 2016-06-23 05:03:07 UTC

There is a posted patch about this issue:
https://github.com/dracutdevs/dracut/compare/master...dracut-mailing-devs:1465983624-12964-1-git-send-email-xlpang%40redhat.com

Comment 3 Harald Hoyer 2016-07-21 09:03:18 UTC

(In reply to Xunlei Pang from comment #1)
> There is a posted patch about this issue:
> https://github.com/dracutdevs/dracut/compare/master...dracut-mailing-devs:
> 1465983624-12964-1-git-send-email-xlpang%40redhat.com

I would solve this by changing modules.d/95nfs/module-setup.sh:

installkernel() {
    instmods nfs sunrpc ipv6 nfsv2 nfsv3 nfsv4 nfs_acl nfs_layout_nfsv41_files
}

to

installkernel() {
     hostonly='' instmods nfs sunrpc ipv6 nfsv2 nfsv3 nfsv4 nfs_acl nfs_layout_nfsv41_files
}


What do you think?

Comment 4 Xunlei Pang 2016-07-21 09:31:25 UTC

(In reply to Harald Hoyer from comment #3)
> (In reply to Xunlei Pang from comment #1)
> > There is a posted patch about this issue:
> > https://github.com/dracutdevs/dracut/compare/master...dracut-mailing-devs:
> > 1465983624-12964-1-git-send-email-xlpang%40redhat.com
> 
> I would solve this by changing modules.d/95nfs/module-setup.sh:
> 
> installkernel() {
>     instmods nfs sunrpc ipv6 nfsv2 nfsv3 nfsv4 nfs_acl
> nfs_layout_nfsv41_files
> }
> 
> to
> 
> installkernel() {
>      hostonly='' instmods nfs sunrpc ipv6 nfsv2 nfsv3 nfsv4 nfs_acl
> nfs_layout_nfsv41_files
> }
> 
> 
> What do you think?

If "nfs" is added, then we add the related kernel modules forcely. This is helpful for kdump special unmounted nfs dumping, I'm fine with this modification, thanks!

Comment 6 Xunlei Pang 2016-07-25 17:21:04 UTC

(In reply to Xunlei Pang from comment #4)
> (In reply to Harald Hoyer from comment #3)
> > (In reply to Xunlei Pang from comment #1)
> > > There is a posted patch about this issue:
> > > https://github.com/dracutdevs/dracut/compare/master...dracut-mailing-devs:
> > > 1465983624-12964-1-git-send-email-xlpang%40redhat.com
> > 
> > I would solve this by changing modules.d/95nfs/module-setup.sh:
> > 
> > installkernel() {
> >     instmods nfs sunrpc ipv6 nfsv2 nfsv3 nfsv4 nfs_acl
> > nfs_layout_nfsv41_files
> > }
> > 
> > to
> > 
> > installkernel() {
> >      hostonly='' instmods nfs sunrpc ipv6 nfsv2 nfsv3 nfsv4 nfs_acl
> > nfs_layout_nfsv41_files
> > }
> > 
> > 
> > What do you think?
> 
> If "nfs" is added, then we add the related kernel modules forcely. This is
> helpful for kdump special unmounted nfs dumping, I'm fine with this
> modification, thanks!

BTW, could you please help back port the changes to fedora dracut?
Because I have a rhel7 kdump issue depending on this bug, but we must resolve it in fedora first, then back port fedora's fixes to rhel7.

Thanks!

Comment 7 Michal Kovarik 2016-08-09 11:18:19 UTC

Patch from comment 3 is included in dracut-033-450.el7. Verifying as SanityOnly.

Comment 9 errata-xmlrpc 2016-11-04 08:05:40 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2530.html

Comment 10 Red Hat Bugzilla 2023-09-14 03:27:13 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days